I agree that with all orders being limit orders this enum makes less sense (since the fee that is being returned is not guaranteed, so you may end up selling a bit more or less in the end), but I don't think it's worth the effort to remove it. This would require a breaking API change which I think should be held off for a v2 of the API (potentially in combination with a new settlement contract).

We can keep it in API only, while removing from all the internal code (for code clarity).

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.