[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle backlog of "single trades" more efficiently #36

Open
nlordell opened this issue Apr 5, 2022 · 1 comment
Open

Handle backlog of "single trades" more efficiently #36

nlordell opened this issue Apr 5, 2022 · 1 comment
Labels

Comments

@nlordell
Copy link
Contributor
nlordell commented Apr 5, 2022

At the moment the majority of our solvers will settle trades one by one. Since we wait 30 seconds between batches and mining the solution tx takes some time, we can effectively handle about 0.5-1 individual trades per minute.

This has become noticable in today's testing challenge (worsened by the fact that we were stuck 5 minutes without a solution submission) when multiple people tried to trade non-overlapping tokens at the same time, some trades got very delayed.

This might be important to address, before we get real traffic which might be spiky (e.g. around tweets, etc).

A simple approach would be to make the solver trade return a list of solutions, which we could batch up into a single settlement (or multiple parallel txs). However, this bears the risk of one solution effecting e.g. the uniswap state of another solution and might therefore be invalid by the time the first is mined (maybe we can base all our queries on the pending block which could already have the first solution applied).

We should at least skip the 30s pause when there has been a solution submission in the current run loop.

Original issue gnosis/gp-v2-services#402 by @fleupold

Copy link
github-actions bot commented Sep 2, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant