[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SettlementEncoder method signatures to take self. #39

Closed
nlordell opened this issue Apr 5, 2022 · 1 comment
Closed

Change SettlementEncoder method signatures to take self. #39

nlordell opened this issue Apr 5, 2022 · 1 comment
Labels
stale

Comments

@nlordell
Copy link
Contributor
nlordell commented Apr 5, 2022

Currently there is an implicit assumption that if a SettlementEncoder method fails, then it is in a undefined state and shouldn't be used.

The correct way to describe this with the type system would be to change the method signatures to be:

fn do_thing_that_can_fail(mut self, ...) -> Result<Self>

This way, if there is an error, the we would no longer have access to the encoder.

Original issue gnosis/gp-v2-services#501 by @nlordell
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Aug 27, 2024
@github-actions github-actions bot closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nlordell