[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ProviderConfigs as Available when ready for use. #418

Open
djeremiah opened this issue Mar 30, 2023 · 3 comments
Open

Mark ProviderConfigs as Available when ready for use. #418

djeremiah opened this issue Mar 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@djeremiah
Copy link

What problem are you facing?

Right now, it is possible to create ProviderConfigs as part of a Composition, but the composition never transitions to a Ready status. This appears to be because even though the provider is able to create the ProviderConfig, the reconciler does not mark it Available like is done with managed resources.

How could Crossplane help solve your problem?

The providerconfig.Reconcile function could mark ProviderConfigs as Available.
@djeremiah djeremiah added the enhancement New feature or request label Mar 30, 2023
@bobh66
Copy link
Contributor
bobh66 commented Mar 30, 2023

I have several compositions that create ProviderConfigs and the composites get to the Ready state, so this may be a different issue with the composite/composition.

@haarchri
Copy link
Contributor

https://github.com/upbound/platform-ref-aws/blob/main/package/cluster/eks/composition.yaml#L227 set readinessCheck to none

@negz
Copy link
Member
negz commented May 15, 2023

What does "available" mean for a ProviderConfig? Just that it exists?

In the very early days of Crossplane we set an Available / Ready condition on a ProviderConfig based on some test - e.g. whether the ProviderConfig could be used to list buckets. This was fairly pointless though - being able to list buckets doesn't mean a ProviderConfig will work for what you really want to use it for.

@haarchri haarchri mentioned this issue Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@djeremiah @negz @bobh66 @haarchri