[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all references support resolve and resolution #440

Open
negz opened this issue May 15, 2023 · 0 comments
Open

Not all references support resolve and resolution #440

negz opened this issue May 15, 2023 · 0 comments
Labels

Comments

@negz
Copy link
Member
negz commented May 15, 2023

What happened?

https://github.com/upbound/provider-aws/blob/6075caef/package/crds/aws.upbound.io_providerconfigusages.yaml#L52

We added these new fields in #328. I believe the intention was to affect only cross-resource references. Unfortunately the PR added the fields to generic reference types that are used in many places in Crossplane - for example in the ProviderConfigUsage above.

I believe this means we now have a few reference fields in Crossplane that expose resolve and resolution fields that don't actually do anything. This is a poor user experience - since anyone looking at the API docs might find them and think they can use them.

I would suggest we either:

  • Remove these fields where they're not used.
  • Make sure they work everywhere that they exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant