[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EquateParameters cmp helper #114

Open
negz opened this issue Feb 7, 2020 · 6 comments
Open

Add EquateParameters cmp helper #114

negz opened this issue Feb 7, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on

Comments

@negz
Copy link
Member
negz commented Feb 7, 2020

What problem are you facing?

https://github.com/crossplaneio/stack-gcp/pull/151/files?file-filters%5B%5D=.go#diff-888e0ec46a21ebd2bbdc8d86d4553d9bR92

	return cmp.Equal(in, currentParams, cmpopts.IgnoreInterfaces(struct{ resource.AttributeReferencer }{}))

We frequently use the above cmpopt when determining whether managed resources are equivalent in the IsUpToDate method of each resource's controller. The readability of this option is a little opaque in how it relates to Crossplane.

How could Crossplane help solve your problem?

Perhaps we should add a function like our existing EquateErrors that equates managed resource parameters? This could just be an abstraction on IgnoreInterfaces to begin with.
@negz negz added enhancement New feature or request good first issue Good for newcomers labels Feb 7, 2020
@aditya109
Copy link

Hi @negz, is this issue still valid ?? If yes, I would like to work on this.

@negz
Copy link
Member Author
negz commented Jan 25, 2022

I believe so! CC @muvaf who may have an opinion here.

@aditya109
Copy link
aditya109 commented Jan 26, 2022 •
edited
Loading

Thanks, I will pick this up then.

@muvaf
Copy link
Member
muvaf commented Jan 26, 2022

Hi! I think resource.AttributeReferencer is remnant of the old approach we had taken back then. All reference-related functionality resides in pkg/reference package. In fact pkg/resource/reference.go can be deleted, @aditya109 this could be your first contribution 🙂

@aditya109
Copy link

Thanks @muvaf, will keep it in mind. Excited to try working on this repo.

@stale
Copy link
stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@negz @muvaf @aditya109