[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate command should download/cache full graph of dependencies #5803

Open
Tracked by #5322
jbw976 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #5809
Open
Tracked by #5322

validate command should download/cache full graph of dependencies #5803

jbw976 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #5809

Comments

@jbw976
Copy link
Member
jbw976 commented Jun 27, 2024

The validate command will download dependencies of the extensions that are being validated, as shown in the addDependencies() function: https://github.com/crossplane/crossplane/blob/release-1.16/cmd/crank/beta/validate/manager.go#L191-L205

However, this dependency resolution only goes to the first layer of dependencies - it does not go deeper into the full dependency graph. So if package A depends on B which depends on C, that 2nd layer of dependencies with package C will not be downloaded and cached.

We should download and cache the entire dependency graph, so we have all the schemas for validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants