[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: ESlint rules across repository #581

Open
versecafe opened this issue Jan 22, 2024 · 1 comment
Open

Proposal: ESlint rules across repository #581

versecafe opened this issue Jan 22, 2024 · 1 comment

Comments

@versecafe
Copy link
Contributor

Proposed change

Add eslint package containing a base rule set for the UI library, Utils lib, and the actual app, have them set to use the warn-only plugin to not interrupt current function but rather to serve as a guide for development and to help keep standards across the repo as dozens of people occasionally contribute.

Currently the "lint" command in every single package and app it is set up in does nothing, in @dub/utils and @dub/ui it is set to point to src/ which applies to no files and has no actual rules configured when set to src/**/* to actually point to files, and the Next config could be as simple as:

{
  "extends": "next/core-web-vitals",
  "plugins": ["only-warn"]
}

Or could be done with a full in depth config specifically setup with turborepo in mind.

I'd be happy to implement this and get everything into compliance once the lint rules are agreed on but I wanted to bring up the idea before going off to set it up.

@steven-tey What's your opinion on this?

Copy link
linear bot commented Jan 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant