[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate zenroom_init from zencode_init on context creation #895

Open
jaromil opened this issue Jun 30, 2024 · 1 comment
Open

Separate zenroom_init from zencode_init on context creation #895

jaromil opened this issue Jun 30, 2024 · 1 comment
Assignees
@jaromil
Labels
enhancement

Comments

@jaromil
Copy link
Member
jaromil commented Jun 30, 2024

Following analysis on #892 that mandates init also on argument validation, it makes sense to separate the two kinds of init: the zencode specific one (zen_init_lua in lua_modules.c) can be called afterwards when all input data is validated, this may permit faster start in some circumstances.
@jaromil jaromil self-assigned this Jun 30, 2024
@jaromil
Copy link
Member Author
jaromil commented Jun 30, 2024

Also quoting @matteo-cristino :

There are still some _err() calls that does not follow the logfmt specified in the conf, but these can not be directly substituted with zerror() since are zenroom or lua initialization error. Another solution should be found for these cases to report errors with the right format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaromil jaromil

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaromil