[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution Errors API #423

Open
terry-delph opened this issue Oct 16, 2019 · 2 comments
Open

Execution Errors API #423

terry-delph opened this issue Oct 16, 2019 · 2 comments

Comments

@terry-delph
Copy link

Is there a service that can get all the Execution Errors associated to a Workflow instance?
I have had a look through the source but maybe I have missed something.
I would expect it to appear as a list of errors on the WorkflowInstance class when retrieving from IWorkflowHost.PersistenceStore.GetWorkflowInstance(workflowId)

Thanks

@danielgerlag
Copy link
Owner

Returning them as part of the instance object could be problematic, as there could potentially be 1000s.
Some of the persistence providers do store them, but there is no API to retrieve them currently... this is a gap that should be addressed.

@terry-delph
Copy link
Author

Thanks Daniel.

I am in the middle of making changes to add additional columns to the ExecutionError table:

  • Type (ex.GetType.ToString() optional
  • Message (already exists, ex.Message)
  • Source (ex.Source) optional
  • StackTrace (ex.StackTrace.Trim) optional
  • TargetSiteName (ex.TargetSite.Name) optional
  • TargetSiteModule (ex.TargetSite.Module.Name) optional
  • HelpLink (ex.HelpLink) optional

I am also adding an additional ErrorCount property to the Workflow instance class.
A new method will be added to the IPersistenceProvider to fetch the errors for a given workflow/s.
This will have feature detection, as not all providers support persisting errors, therefore I will also add a SupportsPersistingErrors boolean property.

I will be adding tests for these changes also.

Should have a PR early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants