[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11/Edge automatically closing the dropdown on a selection #4

Closed
Trinitonn opened this issue Sep 16, 2019 · 4 comments
Closed

IE11/Edge automatically closing the dropdown on a selection #4

Trinitonn opened this issue Sep 16, 2019 · 4 comments

Comments

@Trinitonn
Copy link
Trinitonn commented Sep 16, 2019 •
edited
Loading

Hi Ivan, thank you so much for sharing this great work with us!

I'm not sure if this is a bug or a feature, because I don't know how it's intended to work;
When using IE 11/Edge, the dropdown closes after a selection. In Chrome the dropdown stays open, which makes it easier to choose multiple options.

To reproduce, just use the playground with default settings.

I would be glad if you could consider to make this an option, or - if your intention is that the popup should stay open, perhaps you have some time to check it out. Thanks! 🥇
@darianstlex
Copy link
Owner

Hi Trinitonn, thank you for the feedback, this looks like a bug, unfortunately, I don't have a windows machine, so it might take some time to be fixed.

@Trinitonn
Copy link
Author

Hi again, i opened a pull request to fix this issue, #5.

Feel free to have a look and implement your own fix (or mine). Actually, when I have a second look at this, maybe the eventPath function is unnecessary? Just checking on this.mouseIsHover and !this.isSingle() is enough (haven't tested this though)

@darianstlex
Copy link
Owner

sorry for the delay, you are right, just hover seems enough to detect the click, v1.0.9

@Trinitonn
Copy link
Author

Hi, thanks for the update. Downloaded 1.0.9 now, and it works like a charm in IE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trinitonn @darianstlex