[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior of NaN negation on mips vs simmips #24830

Closed
fsc8000 opened this issue Nov 4, 2015 · 3 comments
Closed

Inconsistent behavior of NaN negation on mips vs simmips #24830

fsc8000 opened this issue Nov 4, 2015 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@fsc8000
Copy link
Contributor
fsc8000 commented Nov 4, 2015

From MIPS builder:

FAILED: none-vm release_mips corelib/nan_infinity_test/01
Expected: Pass
Actual: RuntimeError
CommandOutput[vm]:

stderr:
Unhandled exception:
Expect.isFalse(true) fails.
#0 Expect._fail (package:expect/expect.dart:385:5)
#1 Expect.isFalse (package:expect/expect.dart:120:5)
#2 main (file:///b/build/slave/vm-mips-release-be/build/sdk/out/ReleaseMIPS/generated_tests/corelib/nan_infinity_test_01.dart:57:10)
#3 _startIsolate. (dart:isolate-patch/isolate_patch.dart:263)
#4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:150)

Command[vm]: DART_CONFIGURATION=ReleaseMIPS out/ReleaseMIPS/dart --ignore-unrecognized-flags --package-root=out/ReleaseMIPS/packages/ /b/build/slave/vm-mips-release-be/build/sdk/out/ReleaseMIPS/generated_tests/corelib/nan_infinity_test_01.dart
Took 0:00:01.864000

Short reproduction command (experimental):
python tools/test.py -mrelease -amips --write-debug-log --write-test-outcome-log --copy-coredumps --exclude-suite pkg -t240 corelib/nan_infinity_test/01

FAILED: none-vm release_mips corelib/nan_infinity_test/none
Expected: Pass
Actual: RuntimeError
CommandOutput[vm]:

stderr:
Unhandled exception:
Expect.isFalse(true) fails.
#0 Expect._fail (package:expect/expect.dart:385:5)
#1 Expect.isFalse (package:expect/expect.dart:120:5)
#2 main (file:///b/build/slave/vm-mips-release-be/build/sdk/out/ReleaseMIPS/generated_tests/corelib/nan_infinity_test_none.dart:57:10)
#3 _startIsolate. (dart:isolate-patch/isolate_patch.dart:263)
#4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:150)

Command[vm]: DART_CONFIGURATION=ReleaseMIPS out/ReleaseMIPS/dart --ignore-unrecognized-flags --package-root=out/ReleaseMIPS/packages/ /b/build/slave/vm-mips-release-be/build/sdk/out/ReleaseMIPS/generated_tests/corelib/nan_infinity_test_none.dart
Took 0:00:02.061000

Short reproduction command (experimental):
python tools/test.py -mrelease -amips --write-debug-log --write-test-outcome-log --copy-coredumps --exclude-suite pkg -t240 corelib/nan_infinity_test/none

FAILED: none-vm release_mips language/nan_identical_test
Expected: Pass
Actual: RuntimeError
CommandOutput[vm]:

stderr:
Unhandled exception:
Expect.isFalse(true) fails.
#0 Expect._fail (package:expect/expect.dart:385:5)
#1 Expect.isFalse (package:expect/expect.dart:120:5)
#2 main (file:///b/build/slave/vm-mips-release-be/build/sdk/tests/language/nan_identical_test.dart:25:12)
#3 _startIsolate. (dart:isolate-patch/isolate_patch.dart:263)
#4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:150)

Command[vm]: DART_CONFIGURATION=ReleaseMIPS out/ReleaseMIPS/dart --optimization-counter-threshold=4 --ignore-unrecognized-flags --package-root=out/ReleaseMIPS/packages/ /b/build/slave/vm-mips-release-be/build/sdk/tests/language/nan_identical_test.dart
Took 0:00:05.057000

Short reproduction command (experimental):
python tools/test.py -mrelease -amips --write-debug-log --write-test-outcome-log --copy-coredumps --exclude-suite pkg -t240 language/nan_identical_test

@fsc8000 fsc8000 added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Nov 4, 2015
@fsc8000
Copy link
Contributor Author
fsc8000 commented Nov 4, 2015

@zanderso Not sure, if it is specified how -nan should look like, but we should just be consistent between optimized/unoptimized code and simulator vs hardware.

@lrhn
Copy link
Member
lrhn commented Nov 5, 2015

Seems related to #23563

@rmacnak-google
Copy link
Contributor

MIPS is no longer supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants