[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DocumentJoiner to use enums for join modes #7922

Open
shadeMe opened this issue Jun 25, 2024 · 0 comments
Open

Refactor DocumentJoiner to use enums for join modes #7922

shadeMe opened this issue Jun 25, 2024 · 0 comments
Labels
2.x Related to Haystack v2.0 P3 Low priority, leave it in the backlog type:refactor Not necessarily visible to the users

Comments

@shadeMe
Copy link
Collaborator
shadeMe commented Jun 25, 2024

DocumentJoiner now takes bare strings for its join_mode parameter. This should rewritten to use the enum pattern seen elsewhere in the codebase.
@shadeMe shadeMe added type:refactor Not necessarily visible to the users P3 Low priority, leave it in the backlog 2.x Related to Haystack v2.0 labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 P3 Low priority, leave it in the backlog type:refactor Not necessarily visible to the users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shadeMe