[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invalid HPO-IDs more prominent #122

Open
drseb opened this issue Apr 20, 2016 · 7 comments
Open

Make invalid HPO-IDs more prominent #122

drseb opened this issue Apr 20, 2016 · 7 comments

Comments

@drseb
Copy link
Member
drseb commented Apr 20, 2016

Users might enter wrong HPO-IDs, because:

  • use of a wrong version of HPO , i.e. use classes that do not yet exist in the HPO used by Exomiser
  • use of term-IDs that belong to obsoleted terms in HPO, i.e. the HPO-ID does no longer map to a valid HPO-class
  • entering wrong IDs, e.g. due to typos

Invalid HPO-IDs are left out by Exomiser (correct), but it seems hard to discover such cases for the user. Currently, only the log-file shows lines such as
... [main] ERROR de.charite.compbio.exomiser.core.prioritisers.PhenixPriority - invalid term-id given: HP:1002858
I could not find this information in the resulting HTML file for example.

This is IMHO an important information that users should get, because it might seriously affect the analysis results.

Any ideas?

@drseb
Copy link
Member Author
drseb commented Apr 20, 2016

The HTML even lists under Analysis settings:

...
pedPath: null
hpoIds:
- "HP:0000407"
- "HP:0009830"
- "HP:1002858"
modeOfInheritance: "UNINITIALIZED"
...

which gives the impression, that the given HPO-ID (HP:1002858) was actually used.

@julesjacobsen
Copy link
Contributor

I agree they are an absolutely essential part of the system, although the Analysis settings shows what was submitted so it would be better to flag these up prominently in a seperate section. There is already an error section so this might be a good place to put them.

Given that there are other output formats too without such sections I'm not sure wether having a seperate error file or an error section header is a better idea.

Suggestions?

@visze
Copy link
Contributor
visze commented Apr 20, 2016

My suggestion: I think if the user puts in an invalid HPO ID the analysis should not start. It makes no sense to exclude the HPO-ID because we do not know if it is the main phenotypic feature...

@julesjacobsen
Copy link
Contributor

@visze I like it, plus it makes it much easier to code. InvalidHpoException extends RuntimeException or maybe add an HPO validation step which will do things a slightly less catastrophic manner.

@drseb
Copy link
Member Author
drseb commented Apr 20, 2016

Is it possible that we currently have multiple versions of HPO in Exomiser?

@drseb
Copy link
Member Author
drseb commented Apr 21, 2016

Just mentioning this, because then the validation is dependent on the selected prioritiser.

@julesjacobsen
Copy link
Contributor

Yes - I think there are probably two versions. There is the one which is shipped in the data/phenix directory and another version used in the database for the HP-HP/MP/ZP associations. This is far from ideal.

If at all possible I'd like it so that the ontologiues and associations/phenodigm scores can be updated more easily, even by users directly.

@damiansm damiansm added this to the 9.0.0 milestone Jul 10, 2017
@damiansm damiansm added this to TODO - enhancements in Release 9.0.0 Jul 10, 2017
@damiansm damiansm removed this from Viz improvements in Release 9.0.0 Jul 20, 2017
@damiansm damiansm added this to User experience in Issues triage Oct 30, 2018
@damiansm damiansm moved this from User experience to enhancements in Issues triage Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issues triage
enhancements
Development

No branches or pull requests

4 participants