-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make invalid HPO-IDs more prominent #122
Comments
The HTML even lists under
which gives the impression, that the given HPO-ID (HP:1002858) was actually used. |
I agree they are an absolutely essential part of the system, although the Analysis settings shows what was submitted so it would be better to flag these up prominently in a seperate section. There is already an error section so this might be a good place to put them. Given that there are other output formats too without such sections I'm not sure wether having a seperate error file or an error section header is a better idea. Suggestions? |
My suggestion: I think if the user puts in an invalid HPO ID the analysis should not start. It makes no sense to exclude the HPO-ID because we do not know if it is the main phenotypic feature... |
@visze I like it, plus it makes it much easier to code. |
Is it possible that we currently have multiple versions of HPO in Exomiser? |
Just mentioning this, because then the validation is dependent on the selected prioritiser. |
Yes - I think there are probably two versions. There is the one which is shipped in the data/phenix directory and another version used in the database for the HP-HP/MP/ZP associations. This is far from ideal. If at all possible I'd like it so that the ontologiues and associations/phenodigm scores can be updated more easily, even by users directly. |
Users might enter wrong HPO-IDs, because:
Invalid HPO-IDs are left out by Exomiser (correct), but it seems hard to discover such cases for the user. Currently, only the log-file shows lines such as
... [main] ERROR de.charite.compbio.exomiser.core.prioritisers.PhenixPriority - invalid term-id given: HP:1002858
I could not find this information in the resulting HTML file for example.
This is IMHO an important information that users should get, because it might seriously affect the analysis results.
Any ideas?
The text was updated successfully, but these errors were encountered: