[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue on page /tutorials/tess.html and/or in documentation of get_ror_from_approx_transit_depth #57

Open
ernewton opened this issue Dec 1, 2022 · 2 comments
Open

Issue on page /tutorials/tess.html and/or in documentation of get_ror_from_approx_transit_depth #57

ernewton opened this issue Dec 1, 2022 · 2 comments

Comments

@ernewton
Copy link
ernewton commented Dec 1, 2022

This case study has: "r_pl = pm.Deterministic("r_pl", ror * r_star)" for calculating the planetary radius. According to the documentation for get_light_curve, r_pl is in units of solar radii, not the host star radius. However, this example gets ror from get_ror_from_approx_transit_depth, for which the documentation says ror is the radius ratio and is not explicit about units. I suggest clarifying in both the case study tutorial and in the documentation about the units.
@dfm
Copy link
Member
dfm commented Dec 6, 2022

Hi @ernewton — I believe that the docs and the tutorial are both correct in this case. r_pl has units of Solar radii, and when we call get_light_curve, we use:

        light_curves = (
            star.get_light_curve(orbit=orbit, r=r_pl, t=x[mask], texp=texp)
            * 1e3
        )

where all the arguments have the units consistent with the docs. Can you clarify what the issue is that you're seeing?

@dfm
Copy link
Member
dfm commented Dec 6, 2022

Note that when we call r_pl = pm.Deterministic("r_pl", ror * r_star) we're converting ror from relative units to r_pl in units of Solar radii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfm @ernewton