[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Enabling Vibrancy and backdrop-filter blur doesn't render properly #39529

Open
3 tasks done
RoyalFoxy opened this issue Aug 16, 2023 · 15 comments
Open
3 tasks done
Labels
25-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/

Comments

@RoyalFoxy
Copy link

Preflight Checklist

Electron Version

25.5.0

What operating system are you using?

macOS

Operating System Version

macOS sonoma 14

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

No response

Expected Behavior

Have an electron application with vibrancy enabled. Get some text or other element absolutely positioned and add another element with both a transparent background and the backdrop-filter set to blur(10px) (or any value). This should just have the text in the background render blurred.

Actual Behavior

However the text in the background gets blurred and not at the same time. An example can be found under the additional informations section

Testcase Gist URL

No response

Additional Information

I have used the latest bleeding edge version of vscode for this using the vibrancy extension to add vibrancy to vscode. As you can see I added the background color and the backdrop-filter and it produces a weird effect.

image

I also tried this in plain html and chrome (minus the vibrancy of the browser of course) and it works as expected.

image

This seems to also affect other operating systems as well. I sadly cannot test it myself but I saw that another issue that tackled the same bug as I do here (that issue now has an unsupported electron version) had reports from both windows and macOS. This is the issue I referenced.

@codebytere codebytere added the blocked/need-repro Needs a test case to reproduce the bug label Aug 16, 2023
@github-actions
Copy link
Contributor

Hello @RoyalFoxy. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro Needs a test case to reproduce the bug label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

@RoyalFoxy
Copy link
Author
RoyalFoxy commented Aug 16, 2023

https://gist.github.com/RoyalFoxy/50b890de9e9fdadf098e8594877f0ade

Also found out that any text, not just absolutely positioned one is affected...

@github-actions github-actions bot removed the blocked/need-repro Needs a test case to reproduce the bug label Aug 16, 2023
@jkleinsc jkleinsc added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 25-x-y labels Aug 21, 2023
@YousufSSyed
Copy link

@RoyalFoxy Oh my god how did you find this bug?! I was wondering my CSS wasn't working and I noticed a difference when I turned vibrancy off in Obsidian.

@RoyalFoxy
Copy link
Author
RoyalFoxy commented Oct 19, 2023

This bug is already there since a handful of versions, Im not the first one to notice and report it. It just never got worked on and the issue created for it suddenly dropped out of the range of supported versions so I created this new issue and I will continue doing that until its fixed because my vscode looks inconsistent in its current state

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@YousufSSyed
Copy link

Yes this bug still affects me or us.

@skovhus
Copy link
skovhus commented Jan 22, 2024

Also affected.

@RoyalFoxy
Copy link
Author
RoyalFoxy commented Jan 22, 2024

I've tested my previous fiddle with the latest versions of 26, 27, 28 and alpha 29 and all are also affected. I have also changed the vibrancy to "fullscreen-ui" as "dark" is deprecated and there is no change.

Would be very much appreciated if this gets fixed/worked on

@RoyalFoxy
Copy link
Author
RoyalFoxy commented Mar 13, 2024

Mainly as a reminder, this is still an issue. Even if it's not something very critical, I think it would be still a very good thing to fix as it would allow having apps feel even more native as pure native apps on windows and macos already support having the main app window be blurred and having blurred elements.

Screenshot 2024-03-13 at 22 49 21

I fully understand that there's very likely more pressing features and bugs to be worked on and I'm very glad Electron gets all the updates and gets actively worked on!

And I would totally try and implement this myself if I knew anything about the codebase at all...

EDIT:
I've also tested it with the newest version of electron, 29 and 30

@mattpark01
Copy link

This should be considered as a major bug.

@RoyalFoxy
Copy link
Author

@mattpark01 I totally agree with you on this one. I'm quite sad my issue has been open since last august and I'm by far not the first one to open an issue for this, the one I can remember just fell out of scope for supported version. Iirc it was opened in 2019... So it's been a bug for many years now :/

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@YousufSSyed
Copy link

bump

@RoyalFoxy
Copy link
Author

Still affected

@RoyalFoxy
Copy link
Author

Tested it with the newest version of electron 31 and the newest alpha 32 and both don't work
Here are the 2 gists
https://gist.github.com/RoyalFoxy/5e899e8a1f653afa511fab56a0aa9db4
https://gist.github.com/RoyalFoxy/f03d3015ed75722a8d8c1703e07eba8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/
Projects
No open projects
Status: Unsorted Items
Development

No branches or pull requests

6 participants