[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect roman function correctly in the documentation #1

Open
erikjuhani opened this issue Dec 21, 2021 · 0 comments
Open

Reflect roman function correctly in the documentation #1

erikjuhani opened this issue Dec 21, 2021 · 0 comments
Labels
good first issue Good for newcomers roman Roman numeral module

Comments

@erikjuhani
Copy link
Owner

Description

Change the value to correctly reflect the API. The API actually returns a value between 0 and 3999.

Zero is parsed as N, nil.

This change should be reflected for the package README as well.

- throw Error("only unsigned integer between range 1..3999 are supported");
+ throw Error("only unsigned integer between range 0..3999 are supported");

https://github.com/erikjuhani/umbrellajs/blob/main/packages/roman/src/roman.ts#L5
@erikjuhani erikjuhani added good first issue Good for newcomers roman Roman numeral module labels Dec 21, 2021
@erikjuhani erikjuhani changed the title Reflect the roman function correctly in the documentation Reflect roman function correctly in the documentation Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers roman Roman numeral module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikjuhani