[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FireMonkey] 4chan-XT compatibility #590

Open
ghost opened this issue Sep 2, 2023 · 4 comments
Open

[FireMonkey] 4chan-XT compatibility #590

ghost opened this issue Sep 2, 2023 · 4 comments
Labels
addon: FireMonkey userscript: compatibility userScript/userCSS Compatibility

Comments

@ghost
Copy link
ghost commented Sep 2, 2023

I have used the 4chan-X userscript for quite a while with FireMonkey. I do recall it originally had some issues1, 2, 3 that have since been worked out. There is currently a more active and modern rewrite in development meant to migrate from CoffeeScript to TypeScript called 4chan-XT. There is a relevant issue where the problem is explained, but the dev does not seem to want to work on compatibility with FireMonkey himself.

I'm not an expert in JavaScript, but I'm just curious: what would be needed to get this script to work with FireMonkey? Once I manually click "run" it works perfectly.

I do understand this is not entirely a FireMonkey problem. Thanks for any response.
@erosman erosman added userscript: compatibility userScript/userCSS Compatibility addon: FireMonkey labels Sep 3, 2023
@erosman
Copy link
Owner
erosman commented Sep 3, 2023

re: 4chan-XT-noupdate.user.js

Manifest V3

Changes in User scripts in Manifest V3, should make all userscript managers more uniform as far as context is concerned.

Currently, @include is not supported in MV3 and points mentioned in #408 are also noteworthy.

Run vs Auto-run

If the code runs correctly via manual "Run", then the issue relates to the context i.e. content vs userScripts context.

What is Violentmonkey injection mode set to?

image

@ghost
Copy link
Author
ghost commented Sep 3, 2023

I'm not sure I understand, I don't use Violentmonkey.

@erosman
Copy link
Owner
erosman commented Sep 3, 2023

I'm not sure I understand, I don't use Violentmonkey.

Oh, sorry. I thought you had tested the userscript in other userscript managers.

There is currently a more active and modern rewrite in development ...

Unfortunately, the code is too large for me to debug. If I know the issue, I might be able to work something out and/or make a suggestion.

@ghost
Copy link
Author
ghost commented Sep 3, 2023

Unfortunate. I wouldn't have any idea what needs to be changed. Thanks anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: FireMonkey userscript: compatibility userScript/userCSS Compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erosman