Type Question: Response.json get type error: is not assignable to type 'undefined'.ts(2345) #15

sinoon · 2020-12-26T02:26:46Z

I got a type error, however, I don't have any idea about is.

Can you help me?

There are npm type:

export interface NPM {
    name: string
    "dist-tag": {
        [tag: string]: string
    }
    maintainers: {
        name: string
        email: string
        avatar: string
    }[]
    time: {
        [version: string]: string
    }
    author: {
        name: string
        email: string
    }
    license: string
}

import { Response, Router } from "farrow-http"

export const router = Router()

router
    .match({
        pathname: "/search",
        query: {
            search: String,
            limit: Number,
        },
    })
    .use(async request => {
        const { search, limit } = request.query
        // search
        const details = await getPackageDetail(search)

        return Response.json({
            code: 0,
            data: details,
        })
    })

And will got

Argument of type '{ code: number; data: NPM[]; }' is not assignable to parameter of type 'JsonType'.
  Type '{ code: number; data: NPM[]; }' is not assignable to type 'undefined'.ts(2345)

The text was updated successfully, but these errors were encountered:

Lucifier129 · 2020-12-26T02:43:32Z

Thx feedback, I will check it later:)

// for now, use `as`  for workaround
return Response.json({
      code: 0,
      data: details,
  } as JsonType)

uinz · 2020-12-26T03:05:56Z

export interface NPM {
    name: string
    "dist-tag": {
        [tag: string]: string
    }
    maintainers: {
        name: string
        email: string
        avatar: string
    }[]
    time: {
        [version: string]: string
    }
    author: {
        name: string
        email: string
    }
    license: string
}

export type NPM  = {
    name: string
    "dist-tag": {
        [tag: string]: string
    }
    maintainers: {
        name: string
        email: string
        avatar: string
    }[]
    time: {
        [version: string]: string
    }
    author: {
        name: string
        email: string
    }
    license: string
}

use type instead of interface

https://www.typescriptlang.org/play?#code/C4TwDgpgBAClC8UDeUDaBrCIBcUDOwATgJYB2A5gLq5wA++RZ5UAvgFABmArqQMbDEA9qSgdSACjA0AlMlZsFZYBEIcAhr2gBBZGyj6opNQFsIuAiQpt2bJSvWaoAIV0G0mHA0tVzjKzdBIKABhBFcDDCxfb2ovJmsFQOgAETCkPQMjU2j4mzYAGwhgKDU0lhK8KC0CoqgAIzKK5xri3ka1SuCWqAATdsrkhTFxNWlOCTqx4d4piR6xhSA

sinoon · 2020-12-26T04:13:52Z

export interface NPM {
    name: string
    "dist-tag": {
        [tag: string]: string
    }
    maintainers: {
        name: string
        email: string
        avatar: string
    }[]
    time: {
        [version: string]: string
    }
    author: {
        name: string
        email: string
    }
    license: string
}

export type NPM  = {
    name: string
    "dist-tag": {
        [tag: string]: string
    }
    maintainers: {
        name: string
        email: string
        avatar: string
    }[]
    time: {
        [version: string]: string
    }
    author: {
        name: string
        email: string
    }
    license: string
}

use type instead of interface

https://www.typescriptlang.org/play?#code/C4TwDgpgBAClC8UDeUDaBrCIBcUDOwATgJYB2A5gLq5wA++RZ5UAvgFABmArqQMbDEA9qSgdSACjA0AlMlZsFZYBEIcAhr2gBBZGyj6opNQFsIuAiQpt2bJSvWaoAIV0G0mHA0tVzjKzdBIKABhBFcDDCxfb2ovJmsFQOgAETCkPQMjU2j4mzYAGwhgKDU0lhK8KC0CoqgAIzKK5xri3ka1SuCWqAATdsrkhTFxNWlOCTqx4d4piR6xhSA

Yeah, that's ok, Thank you!

is interesting why interface is type error but type is ok?

uinz · 2020-12-26T08:24:04Z

I think it is a bug in typescript

Lucifier129 · 2020-12-26T08:30:51Z

@sinoon @uinz Maybe we can file an issue for Typescript to see whether is a bug or not:-)

tqma113 · 2021-01-27T17:05:11Z

microsoft/TypeScript#15300 (comment)

Lucifier129 added the bug Something isn't working label Dec 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Type Question: Response.json get type error: is not assignable to type 'undefined'.ts(2345) #15

Type Question: Response.json get type error: is not assignable to type 'undefined'.ts(2345) #15

Type Question: Response.json get type error: is not assignable to type 'undefined'.ts(2345) #15

Type Question: Response.json get type error: is not assignable to type 'undefined'.ts(2345) #15

Comments