[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@types/jsonwebtoken dependency #56

Closed
AdriVanHoudt opened this issue Jul 13, 2017 · 4 comments
Closed

@types/jsonwebtoken dependency #56

AdriVanHoudt opened this issue Jul 13, 2017 · 4 comments
Assignees
@jshcrowthe
Labels
type: question

Comments

@AdriVanHoudt
Copy link
AdriVanHoudt commented Jul 13, 2017 •
edited by hiranya911
Loading

Why is @types/jsonwebtoken a dependency and not a dev dep?
See https://github.com/firebase/firebase-admin-node/blob/master/package.json#L28
@google-oss-bot
Copy link

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

@hiranya911
Copy link
Contributor

I believe it is required to support custom token minting and ID token verification in Firebase Auth.

@AdriVanHoudt
Copy link
Author

But those are just typescript typedefs no? I can't see them being required (but I can be wrong ofc)

@hiranya911
Copy link
Contributor

We might be able to get rid of it. I'll try it out and if all goes well fix it in a future release.

@hiranya911 hiranya911 mentioned this issue Nov 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcrowthe jshcrowthe

Labels
type: question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AdriVanHoudt @hiranya911 @jshcrowthe @google-oss-bot