[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Include raw HTTPS responses in errors #756

Open
alexanderwallin opened this issue Jan 8, 2020 · 5 comments
Open

[FR] Include raw HTTPS responses in errors #756

alexanderwallin opened this issue Jan 8, 2020 · 5 comments
Labels
type: feature request

Comments

@alexanderwallin
Copy link

Is your feature request related to a problem? Please describe.
I am converting APNs tokens to Firebase registration tokens ("FRTs") on-the-fly in a backend push service. Many converted FRTs fail with the error messaging/invalid-argument, with no clues of what's going on. Through some fairly time consuming debugging using the Google API Explorer I was able to get some more details on what was happening, but it's a frustrating process.

Describe the solution you'd like
Provide the raw HTTPS response in the thrown FirebaseMessagingError. The python SDK has this, so I think it makes sense that the Node one would too. It would be especially helpful in cases like this where the error code doesn't make much sense.

Describe alternatives you've considered
The only real option to attain more info would be to use the REST API directly, but that feels a little over the top.

Additional context
There's definitely a possibility that the server or app is misconfigured somehow. Fixing the error is not the point here, though!
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@alexanderwallin alexanderwallin mentioned this issue Jan 8, 2020
Open
@hiranya911
Copy link
Contributor

This is definitely the long term plan. We are currently working towards implementing the same for Java. We can pick up Node.js towards the end of 2020.

@alexanderwallin
Copy link
Author

I'm glad to hear it's on your radar! It's quite a while, a year to introduce a property. Do you accept PRs, or does it entail too much in-house coordinance?

@hiranya911
Copy link
Contributor

If you can introduce the property without any other breaking changes, we can certainly accept it. The overall error handling revamp we are planning is a large-scale breaking change. That's why it's taking time.

@alexanderwallin
Copy link
Author

Alright, good to know! I'll see what I can do. Good luck with the revamp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hiranya911 @alexanderwallin @google-oss-bot