[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WebpushFcmOptions to WebpushFCMOptions #260

Closed
hiranya911 opened this issue Jul 19, 2019 · 4 comments
Closed

Rename WebpushFcmOptions to WebpushFCMOptions #260

hiranya911 opened this issue Jul 19, 2019 · 4 comments
Labels
api: messaging type: cleanup

Comments

@hiranya911
Copy link
Contributor

We should do this rename in order to be consistent with Go conventions. This is unfortunately a breaking change, and therefore cannot be implemented until we plan a major release.
@google-oss-bot
Copy link
Collaborator

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@chemidy
Copy link
Contributor
chemidy commented Jul 19, 2019

Yes this is a breaking change, But i think the option currently not working because the param name is fcmOptions instead of fcm_options (this is fixed in #256 )

@hiranya911
Copy link
Contributor Author

Backend API accepts both fcmOptions and fcm_options. This was confirmed with the FCM team a while ago.

@hiranya911 hiranya911 mentioned this issue Feb 20, 2020
Merged
@hiranya911
Copy link
Contributor Author

Fixed in the v4 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: messaging type: cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hiranya911 @chemidy @google-oss-bot