[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and enable automated updates #439

Closed
merlinnot opened this issue May 13, 2019 · 6 comments
Closed

Update dependencies and enable automated updates #439

merlinnot opened this issue May 13, 2019 · 6 comments
Labels
Needs: Attention type: feature request

Comments

@merlinnot
Copy link
Contributor

I'm currently working on a feature (#425) and I'm bumping into issues because of outdated dependencies. I'd like to make a PR with dependency updates, so it doesn't decrease readability of a PR with the feature. I'll go ahead and bump all dependencies that are not breaking.

What do you think about enabling Renovate for this repository? Here's a config we could use:

{
  "bumpVersion": "patch",
  "commitMessageAction": "update",
  "rangeStrategy": "bump",
  "rebaseStalePrs": true,
  "recreateClosed": true
}
@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@merlinnot
Copy link
Contributor Author

I can see that some of Firebase repositories use Repository Gardener. Let me know what's your preference and if I can help you somehow.

@merlinnot merlinnot mentioned this issue May 13, 2019
Closed
@joehan
Copy link
Contributor
joehan commented May 13, 2019

I like the idea of enabling Repository Gardener on this repo. The one snag I see is that we regularly sync this with a private repo, which might complicate things, but as long as we only enable it on the public side, I think it would work. @thechenky, what do you think?

@thechenky
Copy link
Contributor
thechenky commented May 23, 2019 •
edited
Loading

@merlinnot can you give me an example of a Firebase repo that uses this tool? Github is terrible at searching for this so I wasn't able to find any examples.

@thechenky thechenky added Needs: Author Feedback Issues awaiting author feedback and removed Needs: Attention labels May 23, 2019
@merlinnot
Copy link
Contributor Author

Here you go:

https://github.com/GoogleCloudPlatform/repository-gardener
firebase/firebase-js-sdk#1599

@google-oss-bot google-oss-bot added Needs: Attention and removed Needs: Author Feedback Issues awaiting author feedback labels May 24, 2019
@thechenky
Copy link
Contributor

Thanks @merlinnot! I talked with the devs maintaining that repo and they suggested they will likely be moving to Renovate. One issue I see with this is that Renovate is paid - so I'll have to get approval and we would have to use the hosted version. This may take some time to do, so I've filed a bug for myself to look into doing this in the future, at which point I'll loop you in. Unfortunately right now, we're pretty swamped with other higher priority work. Thank you again though for your PRs and your proactive involvement in trying to make this repo better! Really appreciate it.

Internal bug reference: 134178323

I'm going to close out this issue in the meantime since we won't be addressing it in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Attention type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevinajian @joehan @merlinnot @google-oss-bot @thechenky