firebase · kevinajian · Nov 27, 2019 · Jun 21, 2019 · Jun 21, 2019 · Jun 21, 2019
diff --git a/changelog.txt b/changelog.txt
@@ -0,0 +1 @@
+* Allows specifying retry policies for event triggered functions.
diff --git a/integration_test/functions/src/database-tests.ts b/integration_test/functions/src/database-tests.ts
@@ -50,9 +50,7 @@ export const databaseTests: any = functions.database
       .it('should have refs resources', (change, context) =>
         expectEq(
           context.resource.name,
-          `projects/_/instances/${process.env.GCLOUD_PROJECT}/refs/dbTests/${
-            context.params.testId
-          }/start`
+          `projects/_/instances/${process.env.GCLOUD_PROJECT}/refs/dbTests/${context.params.testId}/start`
         )
       )
 

diff --git a/integration_test/functions/src/firestore-tests.ts b/integration_test/functions/src/firestore-tests.ts
@@ -22,9 +22,7 @@ export const firestoreTests: any = functions
       .it('should have well-formatted resource', (snap, context) =>
         expectEq(
           context.resource.name,
-          `projects/${
-            process.env.GCLOUD_PROJECT
-          }/databases/(default)/documents/tests/${context.params.documentId}`
+          `projects/${process.env.GCLOUD_PROJECT}/databases/(default)/documents/tests/${context.params.documentId}`
         )
       )
 

diff --git a/integration_test/functions/src/index.ts b/integration_test/functions/src/index.ts
@@ -4,9 +4,6 @@ import * as admin from 'firebase-admin';
 import { Request, Response } from 'express';
 import * as fs from 'fs';
 
-import * as PubSub from '@google-cloud/pubsub';
-const pubsub = PubSub();
-
 export * from './pubsub-tests';
 export * from './database-tests';
 export * from './auth-tests';
@@ -52,9 +49,7 @@ function callScheduleTrigger(functionName: string, region: string) {
       {
         method: 'POST',
         host: 'cloudscheduler.googleapis.com',
-        path: `projects/${
-          firebaseConfig.projectId
-        }/locations/us-central1/jobs/firebase-schedule-${functionName}-${region}:run`,
+        path: `projects/${firebaseConfig.projectId}/locations/us-central1/jobs/firebase-schedule-${functionName}-${region}:run`,
         headers: {
           'Content-Type': 'application/json',
         },
@@ -199,9 +194,7 @@ export const integrationTests: any = functions
         resp
           .status(500)
           .send(
-            `FAIL - details at https://${
-              process.env.GCLOUD_PROJECT
-            }.firebaseio.com/testRuns/${testId}`
+            `FAIL - details at https://${process.env.GCLOUD_PROJECT}.firebaseio.com/testRuns/${testId}`
           );
       });
   });
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "firebase-functions",
-  "version": "3.0.2",
+  "version": "3.1.0",
   "description": "Firebase SDK for Cloud Functions",
   "keywords": [
     "firebase",
@@ -31,7 +31,7 @@
   },
   "dependencies": {
     "@types/cors": "^2.8.5",
-    "@types/express": "^4.11.1",
+    "@types/express": "^4.17.0",
     "@types/jsonwebtoken": "^8.3.2",
     "@types/lodash": "^4.14.133",
     "cors": "^2.8.4",
@@ -46,21 +46,21 @@
     "@types/mock-require": "^2.0.0",
     "@types/nock": "^10.0.2",
     "@types/node": "^8.10.49",
-    "@types/sinon": "^7.0.12",
+    "@types/sinon": "^7.0.13",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
-    "firebase-admin": "^8.0.0",
+    "firebase-admin": "^8.2.0",
     "istanbul": "^0.4.2",
     "mocha": "^6.1.4",
     "mock-require": "^3.0.3",
     "nock": "^10.0.6",
-    "prettier": "^1.17.1",
+    "prettier": "^1.18.2",
     "sinon": "^7.3.2",
-    "ts-node": "^8.2.0",
+    "ts-node": "^8.3.0",
     "tslint": "^5.17.0",
     "tslint-no-unused-expression-chai": "^0.1.4",
     "tslint-plugin-prettier": "^2.0.0",
-    "typescript": "^3.5.1"
+    "typescript": "^3.5.2"
   },
   "peerDependencies": {
     "firebase-admin": "^8.0.0"

diff --git a/spec/function-builder.spec.ts b/spec/function-builder.spec.ts
@@ -77,14 +77,29 @@ describe('FunctionBuilder', () => {
   it('should allow valid runtime options to be set', () => {
     const fn = functions
       .runWith({
-        timeoutSeconds: 90,
+        failurePolicy: { retry: {} },
         memory: '256MB',
+        timeoutSeconds: 90,
       })
       .auth.user()
       .onCreate((user) => user);
 
     expect(fn.__trigger.availableMemoryMb).to.deep.equal(256);
     expect(fn.__trigger.timeout).to.deep.equal('90s');
+    expect(fn.__trigger.failurePolicy).to.deep.equal({ retry: {} });
+  });
+
+  it("should apply a default failure policy if it's aliased with `true`", () => {
+    const fn = functions
+      .runWith({
+        failurePolicy: true,
+        memory: '256MB',
+        timeoutSeconds: 90,
+      })
+      .auth.user()
+      .onCreate((user) => user);
+
+    expect(fn.__trigger.failurePolicy).to.deep.equal({ retry: {} });
   });
 
   it('should allow both supported region and valid runtime options to be set', () => {
@@ -130,7 +145,39 @@ describe('FunctionBuilder', () => {
       functions
         .region('asia-northeast1')
         .runWith({ timeoutSeconds: 600, memory: '256MB' });
-    }).to.throw(Error, 'TimeoutSeconds');
+    }).to.throw(Error, 'RuntimeOptions.timeoutSeconds');
+  });
+
+  it('should throw an error if user chooses a failurePolicy of type number', () => {
+    expect(() =>
+      functions.runWith({
+        failurePolicy: (1234 as unknown) as boolean,
+      })
+    ).to.throw(Error, 'RuntimeOptions.failurePolicy');
+  });
+
+  it('should throw an error if user chooses a failurePolicy of type string', () => {
+    expect(() =>
+      functions.runWith({
+        failurePolicy: ('string-value' as unknown) as boolean,
+      })
+    ).to.throw(Error, 'RuntimeOptions.failurePolicy');
+  });
+
+  it('should throw an error if user chooses a failurePolicy.retry of type number', () => {
+    expect(() =>
+      functions.runWith({
+        failurePolicy: { retry: (1234 as unknown) as object },
+      })
+    ).to.throw(Error, 'RuntimeOptions.failurePolicy.retry');
+  });
+
+  it('should throw an error if user chooses a failurePolicy.retry of type string', () => {
+    expect(() =>
+      functions.runWith({
+        failurePolicy: { retry: ('string-value' as unknown) as object },
+      })
+    ).to.throw(Error, 'RuntimeOptions.failurePolicy.retry');
   });
 
   it('should throw an error if user chooses an invalid memory allocation', () => {
@@ -152,13 +199,13 @@ describe('FunctionBuilder', () => {
       return functions.runWith({
         timeoutSeconds: 1000000,
       } as any);
-    }).to.throw(Error, 'TimeoutSeconds');
+    }).to.throw(Error, 'RuntimeOptions.timeoutSeconds');
 
     expect(() => {
       return functions.region('asia-east2').runWith({
         timeoutSeconds: 1000000,
       } as any);
-    }).to.throw(Error, 'TimeoutSeconds');
+    }).to.throw(Error, 'RuntimeOptions.timeoutSeconds');
   });
 
   it('should throw an error if user chooses an invalid region', () => {