[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash: Dozen of crashes inside RCNFetch.m line 221 __81-[RCNConfigFetch refreshInstanceIDTokenAndFetchCheckInInfoWithCompletionHandler:] #4622

Closed
dimaosa opened this issue Jan 8, 2020 · 15 comments · Fixed by #4745
Closed

Crash: Dozen of crashes inside RCNFetch.m line 221 __81-[RCNConfigFetch refreshInstanceIDTokenAndFetchCheckInInfoWithCompletionHandler:] #4622

dimaosa opened this issue Jan 8, 2020 · 15 comments · Fixed by #4745
Assignees
@morganchen12
Labels
api: remoteconfig closed-by-bot needs-info no-recent-activity

Comments

@dimaosa
Copy link
dimaosa commented Jan 8, 2020

Describe your environment

  • Xcode version: 11.2.1
  • Firebase SDK version and Firebase Component:
 - FirebaseRemoteConfig (4.4.3):
    - FirebaseABTesting (~> 3.1)
    - FirebaseAnalyticsInterop (~> 1.4)
    - FirebaseCore (~> 6.2)
    - FirebaseInstanceID (~> 4.2)
    - GoogleUtilities/Environment (~> 6.2)
    - "GoogleUtilities/NSData+zlib (~> 6.2)"
    - Protobuf (>= 3.9.2, ~> 3.9)

Describe the problem

We are receiving dozen of crashes after updating Pods ->
image

Steps to reproduce:

  1. What happened?
    Crashes occur randomly and we are not able to reproduce it in debug.

Around 4% of users have this crash.

Relevant Code:

image

Crashed: com.apple.main-thread
0  **                       0x104fd81f4 __81-[RCNConfigFetch refreshInstanceIDTokenAndFetchCheckInInfoWithCompletionHandler:]_block_invoke_2 + 221 (RCNFetch.m:221)
1  libdispatch.dylib              0x18ae8a610 _dispatch_call_block_and_release + 24
2  libdispatch.dylib              0x18ae8b184 _dispatch_client_callout + 16
3  libdispatch.dylib              0x18ae3d190 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1044
4  CoreFoundation                 0x18b13c5e4 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
5  CoreFoundation                 0x18b1375d8 __CFRunLoopRun + 2004
6  CoreFoundation                 0x18b136adc CFRunLoopRunSpecific + 464
7  GraphicsServices               0x1950bc328 GSEventRunModal + 104
8  UIKitCore                      0x18f231ae0 UIApplicationMain + 1936
9  ***                     0x104845308 main + 22 (**.swift:22)
10 libdyld.dylib                  0x18afc0360 start + 4
@google-oss-bot

This comment has been minimized.

Sign in to view
@rizafran
Copy link
Contributor
rizafran commented Jan 8, 2020

Hi @dimaosa, looks like it's related to this one. Could you try to update your SDK to the latest version and see if you'll still encounter the issue?

@dimaosa
Copy link
Author
dimaosa commented Jan 8, 2020 •
edited
Loading

Hi @rizafran , I will update to latest SDK and check if we would encounter this issue again, thanks

@ryanwilson
Copy link
Member

Any luck @dimaosa?

@dimaosa
Copy link
Author
dimaosa commented Jan 25, 2020

Hi @ryanwilson , we are still receiving crashes in this method, even when we used latest libs, I will provide more details on Monday

@dimaosa
Copy link
Author
dimaosa commented Jan 27, 2020

With following libs versions, we still receive the same crash

  - FirebaseRemoteConfig (4.4.6):
    - FirebaseABTesting (~> 3.1)
    - FirebaseAnalyticsInterop (~> 1.4)
    - FirebaseCore (~> 6.2)
    - FirebaseInstanceID (~> 4.2)
    - GoogleUtilities/Environment (~> 6.2)
    - "GoogleUtilities/NSData+zlib (~> 6.2)"
    - Protobuf (>= 3.9.2, ~> 3.9)

@dmandar
Copy link
Contributor
dmandar commented Jan 31, 2020

Hi, this code has been updated in #4745 . Please retest in the next release and reopen if still an issue.

@dmandar dmandar closed this as completed Jan 31, 2020
@dimaosa
Copy link
Author
dimaosa commented Jan 31, 2020

Thanks @dmandar , I will wait for the next release

@paulb777 paulb777 added this to the M64 milestone Jan 31, 2020
@paulb777
Copy link
Member

@dmandar Added M64 tag to indicate release version. Reopening until #4745 merges.

@paulb777 paulb777 reopened this Jan 31, 2020
@dmandar dmandar mentioned this issue Jan 31, 2020
Merged
@Nac11
Copy link
Nac11 commented Feb 22, 2020

I am still facing this issues. I am on version 4.4.7. Tried updating pods a dozen times.

testflight_feedback (6).zip

@morganchen12
Copy link
Contributor

@Nac11 are you able to reproduce the crash consistently?

@Nac11
Copy link
Nac11 commented Feb 23, 2020

@Nac11 are you able to reproduce the crash consistently?

@morganchen12 Yes. This crash occurs when both of these things happen together:

  • Opening the app from universal links or push notifications (basically deeplinking).
  • The minimum refresh interval the Remote config has expired.

I have noticed that during these deeplink scenarios, the fetchAndActivate method of my code is called twice in quick succession. (which is a bug in my app and I have resolved it.)
But regardless, my concern is that Remote config could give me an error in such cases if something is wrong and not crash.

I am able to reproduce this crash consistently. Will be happy to share you more logs if that is helpful.

@morganchen12
Copy link
Contributor

Can you share the app that's crashing (or a separate sample app that also crashes)? The stack trace you posted is slightly different from the original issue, so having a repro to figure out the root cause of the crash would be very helpful.

@morganchen12 morganchen12 reopened this Feb 24, 2020
@morganchen12 morganchen12 removed this from the M64 - 6.17.0 milestone Feb 24, 2020
@morganchen12 morganchen12 self-assigned this Feb 24, 2020
@google-oss-bot
Copy link

Hey @dimaosa. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 3 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

@google-oss-bot
Copy link

Since there haven't been any recent updates here, I am going to close this issue.

@dimaosa if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.

@firebase firebase locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morganchen12 morganchen12

Labels
api: remoteconfig closed-by-bot needs-info no-recent-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not continue with fetch if we do not get a valid IID. firebase/firebase-ios-sdk
8 participants
@paulb777 @ryanwilson @morganchen12 @dimaosa @dmandar @google-oss-bot @Nac11 @rizafran