[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteConfig.remoteConfig().fetch return .success while the app is offline #4100

Closed
julienbodet opened this issue Oct 16, 2019 · 2 comments · Fixed by #4438
Closed

RemoteConfig.remoteConfig().fetch return .success while the app is offline #4100

julienbodet opened this issue Oct 16, 2019 · 2 comments · Fixed by #4438
Assignees
@dmandar
Labels
api: remoteconfig
Milestone
6.14.0

Comments

@julienbodet
Copy link
julienbodet commented Oct 16, 2019 •
edited
Loading

Describe your environment

  • Xcode version: 11.0 (11A420a)
  • Firebase SDK version: 6.10.0
  • Firebase Component: Remote Config
  • Component version: 6.10.0

Describe the problem

RemoteConfig.remoteConfig().fetch returns a .success status (FIRRemoteConfigFetchStatus) even though I disabled the internet connection.

Note: I never configured defaults via setDefaults, and I ran the app for the first time to be sure no previous config was cached.

Steps to reproduce:

  • Create a new project importing Firebase/RemoteConfig through Cocoapods
  • Follow this guide by skipping the step 2 consisting of setting in-app defaults.
  • Disable the internet connection
  • Run the app, the remote config is fetched

What happened? How can we make the problem occur?
I got a .success status and a nil error even though the app is offline and I didn't set any defaults. I expect to get an error instead.
@google-oss-bot

This comment has been minimized.

Sign in to view
@rizafran
Copy link
Contributor

Thanks for reporting @julienbodet. I was able to get the same behavior, and I'll file this internally to see what's causing the issue. I'll let you know once I have an update.

This was referenced Dec 2, 2019
Closed
Merged
@paulb777 paulb777 added this to the M61 milestone Dec 5, 2019
@firebase firebase locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmandar dmandar

Labels
api: remoteconfig
Projects
None yet
Milestone
6.14.0
Development

Successfully merging a pull request may close this issue.

Throw an error if the fetch response returns an error (irrespective o… firebase/firebase-ios-sdk
6 participants
@paulb777 @julienbodet @morganchen12 @dmandar @google-oss-bot @rizafran