I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

@maletor Thanks for writing in!

The forEach callback takes a QueryDocumentSnapshot because the documents are guaranteed to exist since they are coming from a QuerySnapshot. QueryDocumentSnapshot has support for generics, and you should be able to access T.

For example, the following code snippet using the Post class from the documentation should be valid:

 const posts = db
  .collection('posts')
  .withConverter(PostConverter)
  .get();

posts.forEach((snapshot: QueryDocumentSnapshot<Post>) => {
  const post: Post = snapshot.data();
  ...
});

I would think so as well. But...

Either way, the generic shouldn't be necessary to provide. It should already be there from withConverter returning a type Post like with DocumentReference.

Can you provide a minimal repro so I can see what's going on? It seems to work fine for me in a local test I wrote with that snippet I posted above, even without the generic type specification.

@thebrianchen something like this:

https://gist.github.com/maletor/cdbe979b10c87a892f6cb9bb3db8f0f0

@maletor Thanks for the repro! You are using the admin SDK, which is located at https://github.com/googleapis/nodejs-firestore/. I was able to reproduce this on the admin Node SDK and I'll make a bug fix for it soon.

The root cause is that get() return QuerySnaphot instead of QuerySnapshot<T>, which would remove your typing.

@thebrianchen, doesn't the admin SDK simply use the firestore SDK? It's not doing anything different. It's the same type. Correct me if I'm wrong.

Addendum: Yup, I'm wrong.

https://github.com/googleapis/nodejs-firestore/blob/94ddc897400cafe5a1ee16f3ad0d285411bdd0b2/dev/test/query.ts#L658

Marking as closed. The fix for the admin SDK should go out with the next release.