[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NextJS integration thinks not-found page is non-static #7006

Closed
matthewrj opened this issue Apr 16, 2024 · 1 comment · Fixed by #7012
Closed

NextJS integration thinks not-found page is non-static #7006

matthewrj opened this issue Apr 16, 2024 · 1 comment · Fixed by #7012
Labels
integration: web frameworks type: bug

Comments

@matthewrj
Copy link
matthewrj commented Apr 16, 2024 •
edited
Loading

[REQUIRED] Environment info

firebase-tools: 13.7.2

Platform: macOS

[REQUIRED] Test case

Run firebase deploy --only hosting on a nextjs version 14.2.0 project.

[REQUIRED] Steps to reproduce

Run firebase deploy --only hosting on a nextjs version 14.2.0 project.

[REQUIRED] Expected behavior

No cloud function is created.

[REQUIRED] Actual behavior

Firebase creates a cloud function for the not found page:

  Building a Cloud Function to run this application. This is needed due to:
   • non-static component /_not-found/page

This does not happen with nextjs 14.1.4 so something in 14.2.0 has changed in nextjs that causes firebase to think the not found page is non-static.
@jamesdaniels
Copy link
Member

@leoortizz mind taking a look?

@leoortizz leoortizz mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration: web frameworks type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix non static check for not-found route in Next.js 14.2 firebase/firebase-tools
3 participants
@jamesdaniels @matthewrj @aalej