[go: nahoru, domu]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine Loading
base: 65bf8b1db4d1
Choose a base ref
...
head repository: flutter/engine Loading
compare: df5f1afd4991
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jan 29, 2024

  1. Enable _Float16 "half-float" Functionality Only When Available. (#4… 

    …9851)

# Description:

We're cross-compiling impeller for Android, but x86 Android targets don't  have half float (`_Float16`) _ support. This change disables half float support in `impeller/geometry/half.h` for platforms where the `_Float16` builtin is lacking.

As can be seen in `half.h`, `Float16` support is enabled for all non-windows platforms, which doesn't not allow our use case.

# Issues

I can't seem to find a way to file an issue describing this, but

- [] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @johnoneil
    johnoneil committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    df5f1af View commit details
    Browse the repository at this point in the history
Loading