Commits on Feb 2, 2024

1. Reverts "Add the focus state related methods to the platform dispatch… …

   …er" (#50268)
   
   Reverts #49841
   Initiated by: zanderso
   This change reverts the following previous change:
   Original Description:
   This change augments the platform dispatcher to allow the engine <===> framework to communicate flutter and platform focus changes.
   
   Relevant Issues are:
   * Design doc link: https://github.com/flutter/website/actions/runs/7560898849/job/20588395967
   * Design doc: flutter/flutter#141711
   * Focus in web multiview: flutter/flutter#137443
   
   [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

   

   auto-submit[bot] committed Feb 2, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 0eb7b10
   • Browse repository at this point

   Copy the full SHA

   0eb7b10 View commit details

   Browse the repository at this point in the history

2. [Android] Fix TextInputType.none for devices with physical keyboard (#… …

   …49980)
   
   ## Description
   
   This PR fixes an issue where keystrokes aren't received on Android
   devices with physical keyboards (e.g. rugged Zebra devices) when
   `keyboardType` is set to `TextInputType.none` on a `TextField`.
   
   The logic in `setTextInputClient` and `canShowTextInput` created an
   `inputTarget` with `InputTarget.Type.NO_TARGET` which caused the [input
   connection to short
   circuit](https://github.com/flutter/engine/blob/main/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java#L296)
   and not be established.
   
   Bug introduction PR: #26585
   
   ## Related Issue
   
   flutter/flutter#89983
   
   ## Unit Test Notes
   
   - The existing `showTextInput_textInputTypeNone()` stays green after
   update.
   - `inputConnection_textInputTypeNone()` updated to `assertNotNull`. I
   would make this more specific, but this is my first venture into the
   Flutter engine and don't know enough about those connection attributes.
   
   ## Demo
   
   Video below with Zebra MC9300 device. This issue can also be reproduced
   in a standard android emulator. Simply add a `TextField`, configure
   `keyboardType` to be `TextInputType.none` and attempt to enter text
   after running and giving focus to textfield.
   
   Before
   
   
   https://github.com/flutter/engine/assets/1988098/348ca061-b8b9-4483-956e-0732c1238207
   
   After
   
   
   https://github.com/flutter/engine/assets/1988098/b65c7251-59b4-4c73-9b85-7ac03f47a7e4
   
   ## Pre-launch Checklist
   
   - [x] I read the [Contributor Guide] and followed the process outlined
   there for submitting PRs.
   - [x] I read the [Tree Hygiene] wiki page, which explains my
   responsibilities.
   - [x] I read and followed the [Flutter Style Guide] and the [C++,
   Objective-C, Java style guides].
   - [x] I listed at least one issue that this PR fixes in the description
   above.
   - [ ] I added new tests to check the change I am making or feature I am
   adding, or the PR is [test-exempt]. See [testing the engine] for
   instructions on writing and running engine tests.
   - [ ] I updated/added relevant documentation (doc comments with `///`).
   - [x] I signed the [CLA].
   - [x] All existing and new tests are passing.

   

   bartcone committed Feb 2, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for e292632
   • Browse repository at this point

   Copy the full SHA

   e292632 View commit details

   Browse the repository at this point in the history