[go: nahoru, domu]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine Loading
base: df5f1afd4991
Choose a base ref
...
head repository: flutter/engine Loading
compare: 5584a78a439b
Choose a head ref
  • 2 commits
  • 20 files changed
  • 2 contributors

Commits on Jan 30, 2024

  1. Re-Re-land Manually revert TLHC optimizations (#50155) 

    - ImageReaderSurfaceProducer no longer drops frames when the producer and the consumers are up to two frames out of sync.
- Have the native C++ side of the Android external textures check if a new frame has been pushed and that the texture needs to be updated. This avoids having to schedule a task on the raster thread for each updated texture.
- Notify the engine earlier that a frame is needed when updating a TLHC texture.
- Re-land fix: Don't close the last dequeued from image reader until the dequeued image is no longer used.
    @johnmccutchan
    johnmccutchan committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e49d9da View commit details
    Browse the repository at this point in the history

  2. Revert: "Change how OpenGL textures are flipped in the Android embedd… 

    …er" (#50158)

Reverts #49938.

This broke `packages/packages/camera/camera/example`, and unfortunately
there is no test (in engine, framework, or packages) that would have
caught this. We also suspect (but are not sure) that this is related to
an internal customer reported bug as well (b/322750489).

---

Here is the output _pre_-revert:


![image](https://github.com/flutter/engine/assets/168174/0691feec-67a9-45b1-aa8e-1c692d09430b)

Here is the output _post_-revert:


![image](https://github.com/flutter/engine/assets/168174/016dc79a-1e44-48cf-9ba0-a61397f8e637)
    @matanlurey
    matanlurey committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5584a78 View commit details
    Browse the repository at this point in the history
Loading