[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: flutter update-packages has lots of extra output #116627

Closed
gspencergoog opened this issue Dec 7, 2022 · 4 comments
Closed

Regression: flutter update-packages has lots of extra output #116627

gspencergoog opened this issue Dec 7, 2022 · 4 comments
Labels
c: regression It was better in the past than it is now r: fixed Issue is closed as already fixed in a newer version tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@gspencergoog
Copy link
Contributor
gspencergoog commented Dec 7, 2022 •
edited
Loading

When I run flutter update-packages in the flutter/flutter repo, I get a bunch of extraneous output that didn't used to be printed. This changed recently (in the last few weeks).

This appears to have been a regression that started with #115801, according to git bisect.

Before the regression, the output of flutter update-packages looked like this:

...
Ran pub get in dev/integration_tests/abstract_method_smoke_test in 2.2s...
Ran pub get in packages/integration_test in 2.1s...
Ran pub get in examples/flutter_view in 2.2s...
Ran pub get in dev/integration_tests/flutter_gallery in 2.2s...
Ran pub get in packages/integration_test/integration_test_macos in 2.2s...
Ran pub get in packages/flutter_goldens_client in 2.3s...
Ran pub get in dev/integration_tests/ios_add2app_life_cycle/flutterapp in 2.3s...
Ran pub get in packages/flutter_web_plugins in 2.4s...
Ran pub get in packages/flutter/test_private in 2.4s...
Ran pub get in dev/manual_tests in 2.4s...
Ran pub get in dev/integration_tests/gradle_deprecated_settings in 2.5s...
Ran pub get in examples/image_list in 2.4s...
Ran pub get in dev/tracing_tests in 2.5s...
Ran pub get in dev/tools/vitool in 2.5s...
Ran pub get in dev/integration_tests/non_nullable in 2.5s...
Ran pub get in dev/integration_tests/ios_app_with_extensions in 2.5s...
Ran pub get in examples/splash in 2.5s...
Ran pub get in dev/integration_tests/release_smoke_test in 2.6s...
Ran pub get in dev/integration_tests/android_embedding_v2_smoke_test in 2.6s...
Ran pub get in examples/layers in 2.6s...
Ran pub get in dev/benchmarks/multiple_flutters/module in 2.7s...
Ran pub get in packages/flutter_localizations in 2.6s...
Ran pub get in packages/flutter_goldens in 2.6s...
Ran pub get in packages/flutter/test_private/test in 2.7s...
...

Now it looks like this, with random bold package names interspersed in the output:

...
Ran pub get in examples/platform_view in 2.2s...
Running "flutter pub get" in affected packages...                      ⡿(1.7s)
Ran pub get in examples/platform_channel in 2.2s...
Running "flutter pub get" in affected packages...                      ⢿  frontend_server_client 3.1.0 (3.2.0 available)
  mime 1.0.2 (1.0.3 available)
  path 1.8.2 (1.8.3 available)
  pedantic 1.11.1 (discontinued replaced by lints)
Got dependencies in packages/integration_test/example!
Ran pub get in dev/integration_tests/hybrid_android_views in 2.2s...
  connectivity 3.0.6 (discontinued)
  connectivity_for_web 0.4.0+1 (discontinued)
  device_info 2.0.3 (discontinued)
  frontend_server_client 3.1.0 (3.2.0 available)
  mime 1.0.2 (1.0.3 available)Ran pub get in dev/integration_tests/abstract_method_smoke_test in 2.2s...

  path 1.8.2 (1.8.3 available)
  url_launcher_android 6.0.17 (6.0.22 available)
Running "flutter pub get" in affected packages...                      ⣽Got dependencies in dev/integration_tests/flutter_gallery!
(1.7s)
Ran pub get in packages/integration_test in 2.2s...
Running "flutter pub get" in affected packages...                      ⣾  frontend_server_client 3.1.0 (3.2.0 available)
  mime 1.0.2 (1.0.3 available)
  path 1.8.2 (1.8.3 available)
Got dependencies in packages/flutter_tools!
Ran pub get in examples/flutter_view in 2.2s...
Ran pub get in packages/integration_test/example in 2.2s...
...

cc @nehalvpatel @christopherfujino
@gspencergoog gspencergoog added c: regression It was better in the past than it is now tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 7, 2022
@nehalvpatel
Copy link
Contributor

It looks like I missed the printProgress parameter when I did that PR. I can get a fix up tomorrow, most likely.

@nehalvpatel nehalvpatel mentioned this issue Dec 7, 2022
Merged
8 tasks
@nehalvpatel
Copy link
Contributor

This should be fixed with the merge of #116687. 😃

@bleroux
Copy link
Contributor
bleroux commented Feb 23, 2023

Closing this issue because it was fixed in #116687

@bleroux bleroux closed this as completed Feb 23, 2023
@bleroux bleroux added the r: fixed Issue is closed as already fixed in a newer version label Feb 23, 2023
@github-actions
Copy link
github-actions bot commented Mar 9, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: regression It was better in the past than it is now r: fixed Issue is closed as already fixed in a newer version tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nehalvpatel @bleroux @gspencergoog