[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] texture passthrough for opacity isn't general enough #119474

Closed
jonahwilliams opened this issue Jan 29, 2023 · 2 comments · Fixed by flutter/engine#39237
Closed

[Impeller] texture passthrough for opacity isn't general enough #119474

jonahwilliams opened this issue Jan 29, 2023 · 2 comments · Fixed by flutter/engine#39237
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list

Comments

@jonahwilliams
Copy link
Member

This can be seen on the main wonder screen of wonderous. We don't set the texture contents as being able to defer applying opacity, resulting in an extra pass to draw this texture with opacity before applying the color filter. We should be able to detect this and pull the opacity through the snapshot as normal.
@jonahwilliams jonahwilliams added engine flutter/engine repository. See also e: labels. c: performance Relates to speed or footprint issues (see "perf:" labels) P2 Important issues not at the top of the work list e: impeller Impeller rendering backend issues and features requests labels Jan 29, 2023
@jonahwilliams jonahwilliams mentioned this issue Jan 29, 2023
Merged
@jonahwilliams
Copy link
Member Author

This also doesn't apply to any sort of tiled image and needs to be made more general. There is a slight tradeoff here because we could end up drawing a small part of a large image. In this case, it might make more sense to apply the color filter afterwards.

@jonahwilliams jonahwilliams changed the title [Impeller] texture passthrough doesn't work when images are drawn with a color filter and opacity < 1.0 [Impeller] texture passthrough for opacity isn't general enough Jan 30, 2023
@github-actions
Copy link
github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Impeller] let images with opacity and filters passthrough. jonahwilliams/engine
1 participant
@jonahwilliams