[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an item in a lazy list is being dismissed, we should keep it alive #172

Closed
FlutterIssues opened this issue Nov 9, 2015 · 3 comments
Assignees
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. waiting for PR to land (fixed) A fix is in flight

Comments

@FlutterIssues
Copy link

Issue by Hixie
Friday Sep 25, 2015 at 19:37 GMT
Originally opened as https://github.com/flutter/engine/issues/1347


Currently, if you scroll the item being dismissed off the screen, then scroll it back, it isn't being dismissed anymore. Also, if you scroll it off and wait, after a bit the list jumps up. Not smooth.

@FlutterIssues FlutterIssues added this to the Blue Sky milestone Nov 9, 2015
@FlutterIssues FlutterIssues added bug framework flutter/packages/flutter repository. See also f: labels. labels Nov 9, 2015
@FlutterIssues
Copy link
Author

Comment by Hixie
Friday Sep 25, 2015 at 19:57 GMT


This manifests really badly when you dismiss multiple items at once when you've scrolled off-screen, because once one is entirely done it resets the size cache and this requeries the items for their size, which then causes them to reappear on-screen at their original size.

To reproduce, launch card_collection, dismiss items 0 through 6 with a short pause between each one, then scroll so the top item is item 7. Now watch as nothing happens, then suddenly items bounce up and down.

(You'll want to increase the scheduler time dilation to 100.0 or some such.)

@Hixie Hixie added the f: material design flutter/packages/flutter/material repository. label Nov 20, 2015
@Hixie
Copy link
Contributor
Hixie commented Dec 20, 2015

See also #105; the same fix should fix both.

@Hixie Hixie moved this from Widget stuff to Unsorted in Scrolling Refactor Feb 17, 2017
@Hixie Hixie moved this from Unsorted to Less laziness in Scrolling Refactor Feb 17, 2017
@Hixie Hixie changed the title When an item in a MixedViewport list is being dismissed, we should keep it alive When an item in a lazy list is being dismissed, we should keep it alive May 30, 2017
@Hixie Hixie self-assigned this Jun 23, 2017
@Hixie Hixie added the waiting for PR to land (fixed) A fix is in flight label Jul 1, 2017
@Hixie Hixie closed this as completed Jul 20, 2017
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. waiting for PR to land (fixed) A fix is in flight
Projects
Scrolling Refactor
Less laziness
Development

No branches or pull requests

2 participants