[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'print' throttle its output #232

Closed
FlutterIssues opened this issue Nov 9, 2015 · 8 comments
Closed

Make 'print' throttle its output #232

FlutterIssues opened this issue Nov 9, 2015 · 8 comments
Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project r: invalid Issue is closed as not valid team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@FlutterIssues
Copy link

Issue by Hixie
Monday Oct 26, 2015 at 21:30 GMT
Originally opened as https://github.com/flutter/engine/issues/1804


We should move the debugPrint() logic in rendering/debug.dart to the C++ side. It does seem to have solved the problem of data loss during high-volume logging.

(Having it on the C++ side, as native behaviour of Dart's print() built-in, would mean that all debug output would be throttled the same way, so people writing new frameworks would get this automatically, and people wouldn't have to import rendering.dart to get it even in regular Flutter apps.)

@FlutterIssues FlutterIssues added this to the Blue Sky milestone Nov 9, 2015
@FlutterIssues FlutterIssues added affects: dev experience engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. labels Nov 9, 2015
@Hixie Hixie added c: performance Relates to speed or footprint issues (see "perf:" labels) team Infra upgrades, team productivity, code health, technical debt. See also team: labels. and removed c: performance Relates to speed or footprint issues (see "perf:" labels) labels Dec 12, 2015
@sethladd
Copy link
Contributor

Do we still plan to do this?

@sethladd sethladd added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 14, 2016
@Hixie
Copy link
Contributor
Hixie commented Sep 14, 2016

Yes. Having debugPrint and print do different things leads to a confusing debug experience.

@eseidelGoogle
Copy link
Contributor

FYI @cbracken who's been in print stuff recently. (Not important, just thought you might like to see.)

@efidje efidje mentioned this issue May 8, 2018
@kf6gpe kf6gpe added the P3 Issues that are less important to the Flutter project label May 29, 2020
@kf6gpe kf6gpe modified the milestone: Stretch Goals Jun 1, 2020
@Hixie Hixie removed this from the [DEPRECATED] Stretch Goals milestone Jun 16, 2020
@kf6gpe kf6gpe removed this from the [DEPRECATED] Stretch Goals milestone Jul 7, 2020
@kf6gpe kf6gpe modified the milestone: [DEPRECATED] Stretch Goals Jul 22, 2020
@Hixie Hixie removed this from the - milestone Aug 17, 2020
@pedromassangocode
Copy link

Does this still a valid issue?

@cbracken
Copy link
Member
cbracken commented Aug 27, 2020

debugPrint and debugPrintThrottled (its default implementation) have moved from rendering to lib/src/foundation/print.dart and is still a Dart implementation that buffers lines in a list of strings, then schedules periodic flushes.

The intent here is to shift that logic from the framework to dart:ui in the engine so that people writing alternative frameworks could make use of it without having to pull in bits of the Flutter framework. In that sense, the issue is still valid, but given that a vast majority of our users are using Flutter with the framework (and not just dart:ui), this is likely to remain low on our priority list for the time being. Given that we've pulled it out of the render layer and into the foundation layer of the framework, it's probably even lower priority than it once was.

If someone in the community would like to implement this, I'll gladly review it though!

@pedromassangocode
Copy link

I would like to take this. So what needs to be done is to move the print.dart file to the sky_engine/ui directory?

@Hixie
Copy link
Contributor
Hixie commented Feb 4, 2021

debugPrint has evolved into a more elaborate API than would make sense to squeeze into print, so I think this is now WONTFIX.

@Hixie Hixie closed this as completed Feb 4, 2021
@pedromassangocode pedromassangocode added the r: invalid Issue is closed as not valid label Feb 4, 2021
@github-actions
Copy link
github-actions bot commented Aug 6, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project r: invalid Issue is closed as not valid team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

No branches or pull requests

7 participants