[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename our tools package #59

Closed
1 of 2 tasks
Hixie opened this issue Nov 9, 2015 · 3 comments
Closed
1 of 2 tasks

Rename our tools package #59

Hixie opened this issue Nov 9, 2015 · 3 comments
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@Hixie
Copy link
Contributor
Hixie commented Nov 9, 2015

For sanity, we should make the following changes to our tools package naming:

  • directory flutter/packages/flutter_tools/* => flutter/packages/tools/*
  • package name sky_tools => flutter_tools
@Hixie Hixie added affects: dev experience team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 9, 2015
@Hixie
Copy link
Contributor Author
Hixie commented Dec 16, 2015

I get the feeling I'm the only one who cares about this, so maybe we should just close this bug. Having the directories be named the same as the packages makes sense, even if it means that tab-completion doesn't work well.

@Hixie Hixie modified the milestone: Blue Sky Dec 16, 2015
@Hixie
Copy link
Contributor Author
Hixie commented Dec 16, 2015

Ok, I'm closing this one and #291. I seem to be the only one who wants this, and there are valid arguments against, in particular the clarity that comes from the directory name matching the package name. The only arguments in favour are tab completion and aesthetics.

@Hixie Hixie closed this as completed Dec 16, 2015
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

No branches or pull requests

1 participant