[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnackBar timers don't seem to follow accessibleNavigation rule #64832

Closed
Piinks opened this issue Aug 28, 2020 · 3 comments
Closed

SnackBar timers don't seem to follow accessibleNavigation rule #64832

Piinks opened this issue Aug 28, 2020 · 3 comments
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@Piinks
Copy link
Contributor
Piinks commented Aug 28, 2020

MediaQuery.accessibleNavigation states

When this setting is true, features such as timeouts should be disabled or have minimum durations increased.

This seems to be partially followed by SnackBars.

When accessibleNavigation is true, and a SnackBar has an action, the timeout is disabled, allowing the user to dismiss the SnackBar manually using the action.

When accessibleNavigation is true, and a SnackBar does not have an action, the timeout runs as usual. It would seem by the documentation above that in this case the timer should be longer. We should confirm this and update the timers for accessibleNavigation.

BTW - the timers are currently set in ScaffoldState
#64101 will move this from ScaffoldState to ScaffoldMessengerState
@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Aug 28, 2020
@jonahwilliams
Copy link
Member

I believe the current behavior is correct: see go/snackbar-a11y-spec

@Piinks
Copy link
Contributor Author
Piinks commented Aug 31, 2020

Thanks @jonahwilliams!
FYI @HansMuller
I'll close this then. :)

@Piinks Piinks closed this as completed Aug 31, 2020
@Piinks Piinks mentioned this issue Aug 31, 2020
Merged
12 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonahwilliams @Piinks @TahaTesser