[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffolds are not removed in Release Mode #65212

Closed
creativecreatorormaybenot opened this issue Sep 4, 2020 · 7 comments · Fixed by #65416
Closed

Scaffolds are not removed in Release Mode #65212

creativecreatorormaybenot opened this issue Sep 4, 2020 · 7 comments · Fixed by #65416
Labels
f: material design flutter/packages/flutter/material repository. found in release: 1.22 Found to occur in 1.22 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on

Comments

@creativecreatorormaybenot
Copy link
Contributor

I think that I might have spotted a mistake in release mode @Piinks @HansMuller of #64101:

The _unregister line will not remove the state from the hash set in release mode:

  void _unregister(ScaffoldState scaffold) {
    assert(_scaffolds.remove(scaffold));
  }
Closed
13 tasks
@creativecreatorormaybenot
Copy link
Contributor Author

My proposal to fix this (if this is indeed a bug), is in #65214.

@pedromassangocode
Copy link

Hi @creativecreatorormaybenot
Please share your flutter doctor -v.

@creativecreatorormaybenot
Copy link
Contributor Author

@pedromassango This is just a code error (afaic) that was introduced in the linked PR #64101 yesterday (merged into master).

@pedromassangocode
Copy link

Please share it just for the records.

@pedromassangocode pedromassangocode added in triage Presently being triaged by the triage team waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds labels Sep 4, 2020
@creativecreatorormaybenot
Copy link
Contributor Author

@pedromassango

Flutter version 48f1a0a8d5531a08de638f087678770dd26b01ba.

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 4, 2020
@pedromassangocode pedromassangocode added found in release: 1.22 Found to occur in 1.22 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on and removed in triage Presently being triaged by the triage team labels Sep 7, 2020
@HansMuller HansMuller added the f: material design flutter/packages/flutter/material repository. label Sep 8, 2020
@HansMuller
Copy link
Contributor

@creativecreatorormaybenot - good catch! That is indeed a bug.

@HansMuller HansMuller mentioned this issue Sep 8, 2020
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. found in release: 1.22 Found to occur in 1.22 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-land ScaffoldMessenger HansMuller/flutter
Fix release mode scaffold unregister
3 participants
@HansMuller @creativecreatorormaybenot @pedromassangocode