[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for Bundler to manage Gem dependencies #148349

Conversation

KarimEbrahemAbdelaziz
Copy link

What's this feature about?

Added --[no]-use-bundler flag so that you can manage Cocoapods gem using Bundler and execute bundle exec pod install rather than pod install if Gemfile exists.

Closes these issues:

  1. [DISCUSSION] Use bundler to configure dependencies for iOS project
  2. Don't rely on global pod installation, use bundled version

How to Test this PR?

  1. Checkout the branch.
  2. Create new project using --use-bundler via this command flutter create --platform ios,android test_case --use-bundler. It will make sure to add the proper Gemfile for you inside ios folder.
  3. Add new dependency to the pubspec.yaml file that have a native counterpart. For example webview_flutter:
  4. Build the iOS project via this command to build using Bundler, flutter build ios --use-bundler

Pre-launch Checklist

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels May 14, 2024
Copy link
@JalalAddinOkbi JalalAddinOkbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@KarimEbrahemAbdelaziz KarimEbrahemAbdelaziz force-pushed the feature/support-bundler-for-gem-dependencies branch 3 times, most recently from e1a4e34 to 699654a Compare May 16, 2024 05:35
@KarimEbrahemAbdelaziz KarimEbrahemAbdelaziz force-pushed the feature/support-bundler-for-gem-dependencies branch from 699654a to 49aea07 Compare May 17, 2024 07:09
@christopherfujino
Copy link
Member

Thank you for putting out this PR! However, I actually don't think we should make this change as we're planning to deprecate cocoapods, see #22998.

I apologize for the inconvenience, and I hope to see you around with future contributions!

@KarimEbrahemAbdelaziz
Copy link
Author

Thank you @christopherfujino :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants