[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets] Fix macOS host build failure when there are no frameworks to sign. #150742

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bdero
Copy link
Member
@bdero bdero commented Jun 25, 2024

When the "${native_assets_path}"*.framework glob doesn't resolve anything, the bash will run the loop once with the original unglobbed value: /path/to/native/assets/*.framework. Skip this case to prevent the build from failing when there are no frameworks to sign.

To reproduce this build failure:

  1. Enable native assets in the Flutter tool: flutter config --enable-native-assets
  2. Create a Flutter project with the default template: flutter create test_native_assets
  3. Add a build hook that does nothing (hook/build.dart).
  4. Try to build/run the app: flutter run --debug -d macos

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 25, 2024
@bdero bdero force-pushed the bdero/fix-native-assets-empty branch from 789a88b to e0619b9 Compare June 25, 2024 01:09
@bdero bdero force-pushed the bdero/fix-native-assets-empty branch from a0d226c to c4233e7 Compare June 25, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant