[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camera_web] Don't require enumerating cameras on web #6369

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[camera_web] Don't require enumerating cameras on web #6369

wants to merge 4 commits into from

Conversation

kristoffer-zliide
Copy link

Enumerating available cameras on web requires permission and activates hardware. This PR allows initializing the camera controller without having to enumerate available cameras first.

flutter/flutter#145541

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@kristoffer-zliide
Copy link
Author

At the time of this writing, a version of the example app where the enumeration of availableCameras have been replaced with

    _cameras = <CameraDescription>[
      const CameraDescription(
        name: 'Front',
        lensDirection: CameraLensDirection.front,
        sensorOrientation: 0,
      ),
      const CameraDescription(
        name: 'Back',
        lensDirection: CameraLensDirection.back,
        sensorOrientation: 0,
      ),
    ];

can be tried out here. Note that, contrary to the normal example app, it doesn't ask for permission before you tap on a camera.

QoLTech
QoLTech reviewed Mar 27, 2024
View reviewed changes
Copy link
@QoLTech QoLTech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

We're creating an application that uses the camera and we're baffled that we need to show a permission dialog to get the list of camera devices. We also noticed that devices with many cameras take a longer time to initialize and display a preview.

stuartmorgan
stuartmorgan reviewed May 8, 2024
View reviewed changes
packages/camera/camera/lib/src/camera_controller.dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in this file because the example had an existing issue, or is the web change breaking to clients?

@stuartmorgan
Copy link
Contributor

@kristoffer-zliide This appears to be failing web tests in CI (web_platform_tests_shard_2)

@ditman It looks like this is otherwise waiting for your review.

@stuartmorgan
Copy link
Contributor

From triage: @kristoffer-zliide Are you planning on fixing the failing tests in this PR?

@stuartmorgan
Copy link
Contributor

Marking as a draft pending resolution of the test failures.

@stuartmorgan stuartmorgan marked this pull request as draft June 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan left review comments

@QoLTech QoLTech QoLTech left review comments

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
p: camera platform-web
Projects
None yet
Milestone
No milestone
3 participants
@kristoffer-zliide @stuartmorgan @QoLTech