[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headerBuilder - please add a note that this widget is only shown on narrow screens. #10691

Closed
1 task
newskylabs opened this issue Jun 1, 2024 · 8 comments
Closed
1 task

headerBuilder - please add a note that this widget is only shown on narrow screens. #10691

newskylabs opened this issue Jun 1, 2024 · 8 comments
Assignees
@ericwindmill
Labels
a.tut.codelab-google Relates to codelabs hosted on codelabs.developers.google.com d.enhancement Improves docs with specific ask e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.

Comments

@newskylabs
Copy link
newskylabs commented Jun 1, 2024 •
edited by ericwindmill
Loading

Page URL

https://firebase.google.com/codelabs/firebase-auth-in-flutter-apps#4

Page source

No response

Describe the problem

Hi,

When testing on a wide screen the headerBuilder widget is not displayed. Therefore the reader very probably will spend some time to debug the code in order to find the "bug" - which will be in vain as it is not a bug at all: the headerBuilder widget is only shown on narrow screens...

The sideBuilder widget has the opposite behaviour: it is only shown on wide screens. However, in the 'Side Builder' paragraph the following can be read: "The widget that sideBuilder returns will be displayed to the left of the sign in form, and only on wide screens." So the reader will expect to not see the widget on small screens.

A similar not in the "headerBuilder" paragraph would be very helpful.

Expected fix

Change the text: "Using the SignInScreen.headerBuilder argument, you can add whatever widgets you want above the sign-in form."

to something like: "Using the SignInScreen.headerBuilder argument, you can add whatever widgets you want above the sign-in form. It will be shown, however, only on narrow screens. On wide screens you can use a sideBuilder widget (see later on this page) which will be displayed only on wide screens to the left of the sign in form."

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@newskylabs newskylabs added the from.page-issue Reported in a reader-filed concern label Jun 1, 2024
@newskylabs newskylabs changed the title headerBuilder - please add a note that this widget is only shown on small screens. headerBuilder - please add a note that this widget is only shown on narrow screens. Jun 1, 2024
@sfshaza2
Copy link
Contributor
sfshaza2 commented Jun 1, 2024

A very valid point, @newskylabs. However, can you open this issue against the Firebase docs? That's a different team, a different set of docs, and a different process. thx

@sfshaza2 sfshaza2 closed this as completed Jun 1, 2024
@parlough
Copy link
Member
parlough commented Jun 2, 2024

@sfshaza2 I'll reopen this as the codelab links to here for "Report a mistake" and it's maintained by Eric, covering Flutter too.

@parlough parlough reopened this Jun 2, 2024
@parlough parlough added a.tut.codelab-google Relates to codelabs hosted on codelabs.developers.google.com d.enhancement Improves docs with specific ask e1-hours Effort: < 8 hrs p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. labels Jun 2, 2024
@sfshaza2
Copy link
Contributor
sfshaza2 commented Jun 2, 2024

@parlough, Eric no longer supports Firebase.

@newskylabs newskylabs mentioned this issue Jun 2, 2024
Open
@newskylabs
Copy link
Author

Thank you, @sfshaza2 and @parlough :)

As you said, I just followed the "Report a mistake" link and added the issue. Maybe the link should be redirected as well?

@sfshaza2: ... can you open this issue against the Firebase docs? That's a different team, a different set of docs, and a different process. thx

I reposted the issue on the Firebase docs issue tracker:

headerBuilder - please add a note that this widget is only shown on narrow screens. 29:
firebase/firebase-docs#29

@parlough: Eric no longer supports Firebase.

I also asked to correct the "Report a mistake" link:

The "Report a mistake" link points to the flutter website issues tracker - but should point to firebase-docs issue tracer 30:
firebase/firebase-docs#30

Thanks for your comments,
best wishes...

@parlough
Copy link
Member
parlough commented Jun 3, 2024 •
edited
Loading

Thanks newskylabs for the issue and reposting it! Sorry about the back and forth :)

@domesticmouse @ericwindmill Can you clarify the status of this codelab? Is it still maintained? If so, should we manage issues on this repository or not? It currently links to this issue tracker.

@domesticmouse
Copy link
Contributor

@ericwindmill can you confirm status? I'd suggest deleting if unmaintained.

@parlough and @sfshaza2 this is a firebase codelab, I don't have access to it.

@ericwindmill
Copy link
Contributor

I can fix this. As much as I love deleting things, this is still a popular codelab :)

@ericwindmill ericwindmill reopened this Jun 4, 2024
@ericwindmill
Copy link
Contributor

Fixed by CL #640158830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwindmill ericwindmill

Labels
a.tut.codelab-google Relates to codelabs hosted on codelabs.developers.google.com d.enhancement Improves docs with specific ask e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@domesticmouse @newskylabs @parlough @ericwindmill @sfshaza2