[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing M2 widgets back to the new Material Components widgets catalog #8620

Open
4 tasks
Tracked by #8924
InMatrix opened this issue Apr 24, 2023 · 5 comments
Open
4 tasks
Tracked by #8924
Labels
co.volunteer Community wants to work on this e2-days Effort: < 5 days p2-medium Necessary but not urgent concern. Resolve when possible. t.ui.com.material3 Relates to Material 3 design components t.ui.general Relates to general Flutter app UI topics t.widgets Relates to the Widget catalog

Comments

@InMatrix
Copy link
Contributor
InMatrix commented Apr 24, 2023

Page URL

https://docs.flutter.dev/development/ui/widgets/material/

Page source

https://github.com/flutter/website/tree/main/src/development/ui/widgets/material.md

Describe the problem

The newly updated Material Components widgets catalog (#8574) might have dropped a few widgets in the material library that were introduced by pervious Material versions. One example is the DataTable widget. This widget is still part of the material library and there's no plan to deprecate or replace it. Dropping the widget from the catalog is likely to make it harder to discover. In fact, the current Material widgets catalog is the second highest referrer to the DataTable widget's API doc:
image

Expected fix

I propose the following steps to address the issue:

  • Compare M2 and M3 on material.io and identify components M2 introduced but M3 didn't cover
  • Identify related Flutter widgets
  • Select or create widget preview images which fit the style of existing ones
  • Add those widgets to the new Material widgets catalog page in an "Additional components from M2" section

Additional context

Cc: @guidezpl, @esouthren, @HansMuller, @Nancyhu2023, @atsansone

@InMatrix InMatrix added documentation t.ui.com.material3 Relates to Material 3 design components labels Apr 24, 2023
@ArslanYM
Copy link
ArslanYM commented May 4, 2023

Can I work on this?

@InMatrix
Copy link
Contributor Author
InMatrix commented May 5, 2023

@ArslanYM Thank you for your interest in helping out. I suggest we wait until the updated Material Components widget catalog is available to the public next week at Google I/O. The main challenge of adding additional widgets to the catalog is to select/create widget preview images that fit the style of existing ones. You can better assess whether this is something you'd like to help once you can see the new images in the catalog.

@sfshaza2
Copy link
Contributor

@ArslanYM, yes, you can definitely work on this!

@ArslanYM
Copy link

@sfshaza2 Thankyou, I will get started.

@atsansone atsansone added p2-medium Necessary but not urgent concern. Resolve when possible. e2-days Effort: < 5 days t.ui.general Relates to general Flutter app UI topics t.widgets Relates to the Widget catalog co.volunteer Community wants to work on this ltw-triage labels May 29, 2023
@guidezpl
Copy link
Member
guidezpl commented Mar 7, 2024

For those widgets/components that have dropped out of spec, I'd recommend just mentioning them with links to documentation in the sentence "You can still check out our legacy Material 2 widgets over at their catalog page." These are the ones I could identify:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co.volunteer Community wants to work on this e2-days Effort: < 5 days p2-medium Necessary but not urgent concern. Resolve when possible. t.ui.com.material3 Relates to Material 3 design components t.ui.general Relates to general Flutter app UI topics t.widgets Relates to the Widget catalog
Projects
No open projects
Status: 🚧 In Progress
Development

No branches or pull requests

6 participants