Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: mvdbeek/tusfilter#1
Adds CORS handling to TUS uploads.
TODO: Consider adding separate config setting for uploads
allowed_upload_origin_hostnames
, that could be made looser than other settings (e.g.'*'
), with fall back toallowed_origin_hostnames
, so that other Browser-based applications are able to upload datasets.Example application is GiN (Galaxy in Notebooks), which can upload datasets from a User's computer to Galaxy via JS in a Jupyter Notebook: data is sent from user's computer directly to Galaxy, using credentials provided to GiN. Otherwise, datasets would need to be transferred from User's computer to Jupyter server, then sent e.g. via python/CURL/etc, to the Galaxy server, in order to get around CORS.
How to test the changes?
(Select all options that apply)
License