[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert vuex gridSearchStore and drop unused jobStore #15198

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

kxk302
Copy link
Contributor
@kxk302 kxk302 commented Dec 13, 2022

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.0 milestone Dec 13, 2022
@kxk302 kxk302 mentioned this pull request Dec 13, 2022
4 tasks
import { datasetExtFilesStore } from "./datasetExtFilesStore";
import { jobStore } from "./jobStore";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobStore import and a reference to jobStore removed. Imports sorted.

@dannon dannon changed the title jobStore not used (just referenced in index.js). Removing it. Convert vuex gridSearchStore and drop unused jobStore Dec 14, 2022
@dannon dannon self-assigned this Dec 15, 2022
@dannon dannon modified the milestones: 23.0, 23.1 Jan 9, 2023
@mvdbeek mvdbeek removed this from the 23.1 milestone Jun 21, 2023
@mvdbeek mvdbeek marked this pull request as draft June 21, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants