[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of table properties in CDK DashboardStack #1421

Open
patchwork01 opened this issue Oct 10, 2023 · 0 comments
Open

Remove usage of table properties in CDK DashboardStack #1421

patchwork01 opened this issue Oct 10, 2023 · 0 comments
Assignees

Comments

@patchwork01
Copy link
Collaborator
patchwork01 commented Oct 10, 2023

Background

This is under a parent issue for better support for many tables:

We've previously made table metrics work across all tables at once:

Description

We'd like to avoid the need to redeploy the DashboardStack when a table is added or removed.

Analysis

The DashboardStack references metrics published by TableMetricsLambda, from the TableMetricsStack. It uses these to build a graph of records written in ingest for each table.

We may be able to configure it to generate that graph without needing to know which Sleeper tables exist when the CDK runs. The instance ID and table name are dimensions on the metrics that are used.

We should be able to remove any references to table properties from the CDK module after this, including in the CDK Utils class.

CDK library

It doesn't look like there's currently a way to tell CloudWatch through the CDK to draw a line on a graph for every table name. We're publishing one CloudWatch metric with different values for the instance ID and table name dimension. It looks like in order to separate the metric into different lines on the graph you need to declare individual metrics for each line, and it doesn't look like there's a way to derive that from dimension values.

@patchwork01 patchwork01 added this to the 0.20.0 milestone Oct 10, 2023
@patchwork01 patchwork01 removed this from the 0.20.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants