[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration IO is synchronous #488

Open
RA80533 opened this issue May 8, 2021 · 1 comment
Open

Configuration IO is synchronous #488

RA80533 opened this issue May 8, 2021 · 1 comment

Comments

@RA80533
Copy link
Contributor
RA80533 commented May 8, 2021

Both are annotated as asynchronous functions but neither utilizes asynchronous IO.
@robertbrignull
Copy link
Contributor

Nice catch. Not sure exactly what happened here but I'd guess they were genuinely asynchronous at some point in the past. This looks like a good candidate for a CodeQL query to find unnecessary async methods. I'm surprised that doesn't exist already to be honest as it sounds like it could be broadly useful.

@RA80533 RA80533 mentioned this issue Jun 5, 2021
Closed
@aliscco aliscco mentioned this issue Apr 27, 2023
Open
@snyk-bot snyk-bot mentioned this issue Apr 27, 2023
Open
This was referenced Apr 27, 2023
Open
Open
Open
@aliscco aliscco mentioned this issue Jun 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertbrignull @RA80533