[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOBEL & clang : many complains; tests mising for SOBEL, PREWITT & ROBERTS #507

Open
alaingdl opened this issue Nov 5, 2018 · 1 comment
Open

SOBEL & clang : many complains; tests mising for SOBEL, PREWITT & ROBERTS #507

alaingdl opened this issue Nov 5, 2018 · 1 comment
Assignees
@alaingdl
Labels
good first issue Good for newcomers help wanted Extra attention is needed idl/gdl-only No C++ skills needed

Comments

@alaingdl
Copy link
Contributor
alaingdl commented Nov 5, 2018

as reported by @GillesDuvert , when compiled with clang, many warnings reported on SOBEL()

/Users/travis/build/gnudatalanguage/gdl/src/math_fun_ac.cpp:771:19: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]

             a =   labs ((*p0)[j+1+nbX*(k+1)]+2*(*p0)[j+1+nbX*k]+(*p0)[j+1+nbX*(k-1)]

                   ^

/Users/travis/build/gnudatalanguage/gdl/src/math_fun_ac.cpp:810:9: note: in instantiation of function template specialization 'lib::Sobel_Template<Data_<SpDULong>, Data_<SpDULong>, long>' requested here

         return Sobel_Template<DULongGDL>(static_cast<DULongGDL*> (p0),a);

                ^

no tests in testsuite for SOBEL, PREWITT & ROBERTS
@GillesDuvert
Copy link
Contributor

No warnings anymore, but no tests yet

@GillesDuvert GillesDuvert added good first issue Good for newcomers help wanted Extra attention is needed idl/gdl-only No C++ skills needed labels Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alaingdl alaingdl

Labels
good first issue Good for newcomers help wanted Extra attention is needed idl/gdl-only No C++ skills needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GillesDuvert @alaingdl