I'm on it

I appreciate that an error is preferable to a crash, but this maybe wasn't the fix I had hoped for. :)

I'll make a new issue for the error I guess.

This matches the rest of the code, wasn't going to add an additional error originally

But you can't avoid an error entirely, what is the issue you're facing with the error? What is your alternative?

A more elaborate fix wouldn't be appropriate I'd say as it's a crash that must be avoided, improvements on it would be separate, but unless you suggest adding a more elaborate caching etc., there should always be an error here when accessed incorrectly

Fair enough. Maybe creating an issue wasn't the right tool to use here. Ideally I wouldn't have fumbled the review of #84640 and this could've been discussed prior to merging this change, but alas.

I agree that your fix was the pragmatic fix in this case, and lines up with how get_contact_count does it, and an error is absolutely better than no error. My issue was more with the usage of body_get_direct_state to begin with, but I guess that's a broader topic that's maybe better suited for elsewhere, as you point out.

(Also, I didn't mean for my previous comment to come off as snarky as it did. I appreciate the quick fix, of course.)

Thank you! Making a report was the appropriate thing to make sure the crash was resolved, that shouldn't have been left untended to, but a broader improvement would be good to discuss too :)