[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong state_name_type for France #220

Open
bojanz opened this issue Jul 21, 2021 · 0 comments
Open

Wrong state_name_type for France #220

bojanz opened this issue Jul 21, 2021 · 0 comments

Comments

@bojanz
Copy link
bojanz commented Jul 21, 2021

France currently inherits the default (ZZ) state_name_type of "province".
But the correct state_name_type should be "region", as explained by @comxd in commerceguys/addressing#161

Also, Google Maps API's provide a "region" for the "administrative_area_level_1" field. (@see https://developers.google.com/maps/documentation/javascript/geocoding?hl=fr#GeocodingAddressTypes)

Sources:

https://www.lefrancaisdesaffaires.fr/wp-content/uploads/2016/05/province_et_region.pdf
https://mediateur.radiofrance.com/infos/en-province-en-region/#:~:text=La%20locution%20la%20plus%20commune,parfait%20de%20%C2%AB%20en%20province%20%C2%BB.&text=En%20province%2C%20on%20a%20la,ne%20pas%20%C2%AB%20faire%20Paris%20%C2%BB.

This isn't noticeable because there are no regions defined for France by default, but there's no reason to show a wrong label when people do provide their own region list (in libraries that allow that).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bojanz